Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to serving 0.6.0 #129

Merged
merged 3 commits into from
May 20, 2019
Merged

Conversation

rhuss
Copy link
Contributor

@rhuss rhuss commented May 19, 2019

This PR makes an update to knative-serving 0.6.0 by

  • Updating go.mod dependency to 0.6.0
  • Updating code and tests to still use github.com/knative/serving/pkg/apis/serving/v1alpha1 but with Depectation references update + fix for change from value to pointer types in the serving types.

This change should work now for both 0.5.x and 0.6.0 installations.

Next step would be then to switch the new API but still supporting the v1alpha1 version if this is the highest version supported by the server.

@knative-prow-robot
Copy link
Contributor

Hi @rhuss. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot knative-prow-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels May 19, 2019
@cppforlife
Copy link

/ok-to-test

@knative-prow-robot knative-prow-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 20, 2019
@rhuss rhuss force-pushed the pr/update-0.6.0 branch from 790b4cd to c716095 Compare May 20, 2019 16:13
@sixolet
Copy link
Contributor

sixolet commented May 20, 2019

/approve
/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label May 20, 2019
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhuss, sixolet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 20, 2019
@knative-prow-robot knative-prow-robot merged commit 52b6b23 into knative:master May 20, 2019
rhuss added a commit to rhuss/knative-client that referenced this pull request May 27, 2019
* chore: Update to 0.6.0

* chore: Fix test

* chore: Update modules.txt
maximilien pushed a commit to maximilien/client that referenced this pull request May 28, 2019
* chore: Update to 0.6.0

* chore: Fix test

* chore: Update modules.txt
@rhuss rhuss deleted the pr/update-0.6.0 branch March 9, 2021 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants