Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix replicas *int32 type in describe commands #1312

Merged
merged 2 commits into from
May 17, 2021
Merged

Fix replicas *int32 type in describe commands #1312

merged 2 commits into from
May 17, 2021

Conversation

dsimansk
Copy link
Contributor

Description

Per knative/serving#11170 the actualReplicas, desiredReplicas fields were changed to *int32. This PR brings it to client.

Changes

  • Fix replicas *int32 type in describe commands
  • Update dependencies in separate commit

@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 13, 2021
@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label May 13, 2021
@knative-prow-robot knative-prow-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 13, 2021
@dsimansk dsimansk force-pushed the pr/fix-replicas-type branch from 07ce535 to d7441e7 Compare May 13, 2021 13:05
@knative-prow-robot knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 13, 2021
@dsimansk
Copy link
Contributor Author

@maximilien could you please take a look at this PR? As it might be blocking some of the release preparations and Roland's off on public holiday today.

@maximilien maximilien self-assigned this May 13, 2021
maximilien
maximilien reviewed May 13, 2021
View reviewed changes
Copy link
Contributor

@maximilien maximilien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I generally dislike the idea of using pointers vs actual values for primitive types but I understand the need for absence of the value from the API.
/ok-to-test

@knative-prow-robot knative-prow-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label May 13, 2021
itsmurugappan
itsmurugappan approved these changes May 14, 2021
View reviewed changes
Copy link
Contributor

@itsmurugappan itsmurugappan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label May 14, 2021
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: itsmurugappan, navidshaikh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 17, 2021
@knative-prow-robot knative-prow-robot merged commit a165c6c into knative:main May 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maximilien maximilien maximilien left review comments

@itsmurugappan itsmurugappan itsmurugappan approved these changes

@navidshaikh navidshaikh navidshaikh approved these changes

Assignees

@maximilien maximilien

@itsmurugappan itsmurugappan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dsimansk @knative-prow-robot @maximilien @navidshaikh @itsmurugappan