Added autocompletion for broker #1559
Conversation
There was a problem hiding this comment.
@vyasgun: 0 warnings.
In response to this:
Description
Added completion function for broker describe and delete
Changes
- Added completion function for broker resource
./kn broker describe<tab> abc-broker xyz-broker xyza-brokerReference
Fixes #1373
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
knative-prow-robot
added
the
size/M
Codecov Report
@@ Coverage Diff @@
## main #1559 +/- ##
==========================================
+ Coverage 79.57% 79.59% +0.01%
==========================================
Files 163 163
Lines 8544 8562 +18
==========================================
+ Hits 6799 6815 +16
- Misses 1068 1069 +1
- Partials 677 678 +1
Continue to review full report at Codecov.
|
knative-prow-robot
added
size/L
vyasgun
force-pushed
the
pr/completion-broker
branch
from
f015ea1 to
b001042
Compare
| fakeEventing = &fake.FakeEventingV1{Fake: &clienttesting.Fake{}} | ||
| ) | ||
|
|
||
| var knParams = initialiseKnParams() |
There was a problem hiding this comment.
Might be part of var() block above?
There was a problem hiding this comment.
I thought it would be neater to create diff var blocks for different resources (the one above it is for service resource)
There was a problem hiding this comment.
OK, lets keep it then! :)
|
The following is the coverage report on the affected files.
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dsimansk, vyasgun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
the
approved
Description
Added completion function for broker describe and delete
Changes
Reference
#1373