Added eventtype support

[vyasgun]

Description

Add eventtype support in kn

gvyas-mac:client gvyas$ ./kn eventtype create helloet -t example-type --source example.source.com --broker default
Eventtype 'helloet' successfully created in namespace 'default'.

gvyas-mac:client gvyas$ ./kn eventtype create helloet -t example-type --source example.source.com --broker default
Error: cannot create eventtype 'helloet' in namespace 'default' because: eventtypes.eventing.knative.dev "helloet" already exists
Run 'kn --help' for usage

gvyas-mac:client gvyas$ ./kn eventtype delete helloet
Eventtype 'helloet' successfully deleted in namespace 'default'.

gvyas-mac:client gvyas$ ./kn eventtype list 
NAME                                   TYPE                             SOURCE                                BROKER    SCHEMA   AGE   CONDITIONS   READY   REASON
dev.knative.source.github.push-34cnb   dev.knative.source.github.push   https://github.com/knative/eventing   default            92m   0 OK / 3     False   BrokerDoesNotExist : Broker does not exist

gvyas-mac:client gvyas$ ./kn eventtype describe dev.knative.source.github.push-34cnb
Name:         dev.knative.source.github.push-34cnb
Namespace:    default
Labels:       eventing.knative.dev/sourceName=github-sample
Annotations:  eventing.knative.dev/creator=minikube-user, eventing.knative.dev/lastModifier=minik ...
Age:          23h


Conditions:  
  OK TYPE            AGE REASON
  !! Ready           23h BrokerDoesNotExist
  !! BrokerExists    23h BrokerDoesNotExist
  ?? BrokerReady     23h 

Changes

• Added EventingV1Beta1 client to kn params
• Added list subcommand
• Added describe subcommand
• Added builder for eventtype
• Added create subcommand
• Added delete subcommand
• Added mock client
• Added unit tests

Reference

Fixes #1478

[knative-prow-robot]

@vyasgun: 0 warnings.

In response to this:

Description

Add eventtype support in kn

gvyas-mac:client gvyas$ ./kn eventtype list 
NAME                                   TYPE                             SOURCE                                BROKER    SCHEMA   AGE   CONDITIONS   READY   REASON
dev.knative.source.github.push-34cnb   dev.knative.source.github.push   https://github.com/knative/eventing   default            92m   0 OK / 3     False   BrokerDoesNotExist : Broker does not exist

Changes

• Added EventingV1Beta1 client to kn params
• Added list subcommand

Reference

Fixes #1478

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[codecov]

Codecov Report

Merging #1598 (52e4245) into main (af05208) will increase coverage by 0.15%.
The diff coverage is 85.28%.

@@            Coverage Diff             @@
##             main    #1598      +/-   ##
==========================================
+ Coverage   79.80%   79.96%   +0.15%     
==========================================
  Files         163      171       +8     
  Lines        8824     9089     +265     
==========================================
+ Hits         7042     7268     +226     
- Misses       1089     1109      +20     
- Partials      693      712      +19     

Impacted Files	Coverage Δ
pkg/kn/commands/types.go	87.36% <71.42%> (-1.27%)	⬇️
pkg/kn/commands/eventtype/describe.go	80.95% <80.95%> (ø)
pkg/kn/commands/eventtype/list.go	82.14% <82.14%> (ø)
pkg/kn/commands/eventtype/delete.go	82.60% <82.60%> (ø)
pkg/eventing/v1beta1/client.go	84.00% <84.00%> (ø)
pkg/kn/commands/completion_helper.go	86.47% <87.50%> (+0.07%)	⬆️
pkg/kn/commands/eventtype/create.go	88.88% <88.88%> (ø)
pkg/eventing/v1beta1/client_mock.go	95.23% <95.23%> (ø)
pkg/kn/commands/eventtype/eventtype.go	100.00% <100.00%> (ø)
pkg/kn/commands/flags/eventtype.go	100.00% <100.00%> (ø)
... and 1 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af05208...52e4245. Read the comment docs.

[vyasgun]

/retest

[vyasgun]

/retest

[vyasgun]

/retest

[rhuss]

@vyasgun thanks a lot for the PR ! Unfortunately I'm super busy this week and on PTO next week. @dsimansk @navidshaikh any chance that you could have a review on this PR ?

[dsimansk]

@vyasgun overall the PR looks great. I've add concerns about the width of list output, but otherwise I haven't noticed anything major.

[knative-metrics-robot]

The following is the coverage report on the affected files.
Say /test pull-knative-client-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/eventing/v1beta1/client.go	Do not exist	91.1%
pkg/eventing/v1beta1/client_mock.go	Do not exist	94.7%
pkg/kn/commands/completion_helper.go	92.9%	92.9%	0.1
pkg/kn/commands/eventtype/create.go	Do not exist	92.3%
pkg/kn/commands/eventtype/delete.go	Do not exist	88.2%
pkg/kn/commands/eventtype/describe.go	Do not exist	89.5%
pkg/kn/commands/eventtype/eventtype.go	Do not exist	100.0%
pkg/kn/commands/eventtype/list.go	Do not exist	88.9%
pkg/kn/commands/flags/eventtype.go	Do not exist	100.0%
pkg/kn/commands/types.go	94.2%	93.5%	-0.6

[dsimansk]

Thanks!

/approve
/lgtm

[knative-prow-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dsimansk, vyasgun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [dsimansk]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment