-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(build.sh): Add a watch mode for automatic recompilation #160
Conversation
Hi @rhuss. Thanks for your PR. I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign cppforlife |
/ok-to-test |
@rhuss: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This features uses and requires https://github.com/AgentCosmic/xnotify and should work on any platform Use it with * Watch & compile: build.sh --watch * Watch, compile, test: build.sh --watch --test * Watch, compile, test & verbose output: build.sh --watch --test --verbose (shortcuts -w && -t can be used, too)
/ok-to-test |
@cppforlife @sixolet Could I please have a quick review and potential lgtm ? It's really a small change, for developer convenience. It's totally harmless as it doesn't have to be used and doesn't impact the compilation or release process. In a next step I would add a tempfs for watching which increase compile times ~40% as reported in https://daltontan.com/how-to-compile-go-code-faster-with-ram-disk/24 |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rhuss, sixolet The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* Explain how to build new prow-tests images * Explain the base image
This features uses and requires https://github.com/AgentCosmic/xnotify
and should work on any platform
Use it with
(shortcuts -w && -t can be used, too)