test: use T.TempDir to create temporary test directory
#1660
Conversation
This commit replaces `ioutil.TempDir` with `t.TempDir` in tests. The
directory created by `t.TempDir` is automatically removed when the test
and all its subtests complete.
Prior to this commit, temporary directory created using `ioutil.TempDir`
needs to be removed manually by calling `os.RemoveAll`, which is omitted
in some tests. The error handling boilerplate e.g.
defer func() {
if err := os.RemoveAll(dir); err != nil {
t.Fatal(err)
}
}
is also tedious, but `t.TempDir` handles this for us nicely.
Reference: https://pkg.go.dev/testing#T.TempDir
Signed-off-by: Eng Zer Jun <[email protected]>
knative-prow
bot
added
the
do-not-merge/work-in-progress
![knative-prow[bot]](https://avatars.githubusercontent.com/in/183726?s=60&v=4){kind=small}
There was a problem hiding this comment.
@Juneezee: 0 warnings.
In response to this:
Description
A testing cleanup.
This pull request replaces
ioutil.TempDirwitht.TempDir. We can use theT.TempDirfunction from thetestingpackage to create temporary directory. The directory created byT.TempDiris automatically removed when the test and all its subtests complete.Reference: https://pkg.go.dev/testing#T.TempDir
func TestFoo(t *testing.T) { // before tmpDir, err := ioutil.TempDir("", "") require.NoError(t, err) defer require.NoError(os.RemoveAll(tmpDir)) // now tmpDir := t.TempDir() }Changes
- Replace
ioutil.TempDirwitht.TempDir- Remove redundant
os.RemoveAll(tmpDir)since the temporary directory will be removed automatically once the test complete./lint
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
|
Hi @Juneezee. Thanks for your PR. I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
knative-prow
bot
added
needs-ok-to-test
Signed-off-by: Eng Zer Jun <[email protected]>
knative-prow
bot
removed
the
do-not-merge/work-in-progress
|
/ok-to-test |
knative-prow
bot
added
ok-to-test
|
Thanks, looks good to me! Let's get that in right after we did the 1.4 release. /approve |
knative-prow
bot
added
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Juneezee, rhuss The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow
bot
added
the
approved
|
/retest |
Codecov Report
@@ Coverage Diff @@
## main #1660 +/- ##
=======================================
Coverage 79.48% 79.48%
=======================================
Files 171 171
Lines 12963 12963
=======================================
Hits 10304 10304
Misses 1941 1941
Partials 718 718 Continue to review full report at Codecov.
|
|
/unhold |
knative-prow
bot
removed
the
do-not-merge/hold
Description
A testing cleanup.
This pull request replaces
ioutil.TempDirwitht.TempDir. We can use theT.TempDirfunction from thetestingpackage to create temporary directory. The directory created byT.TempDiris automatically removed when the test and all its subtests complete.Reference: https://pkg.go.dev/testing#T.TempDir
Changes
ioutil.TempDirwitht.TempDiros.RemoveAll(tmpDir)since the temporary directory will be removed automatically once the test complete./lint