Add support for -A variant of --all-namespaces #356
Conversation
-A is my newest favorite kubectl flag, it's so much easier/faster to type than --all-namespaces. kn users should benefit from it too! Signed-off-by: Doug Davis <[email protected]>
There was a problem hiding this comment.
@duglin: 0 warnings.
In response to this:
-A is my newest favorite kubectl flag, it's so much easier/faster to type
than --all-namespaces. kn users should benefit from it too!Signed-off-by: Doug Davis [email protected]
/lintRelease Note
The kubectl `-A` variant of the `--all-namespaces` flag is now supported.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
knative-prow-robot
added
the
size/M
pkg/kn/commands/namespaced_test.go
Outdated
| @@ -95,6 +107,18 @@ func TestGetNamespaceDefaultAllNamespacesUnset(t *testing.T) { | |||
| if actualNamespace != expectedNamespace { | |||
| t.Fatalf("Incorrect namespace retrieved: %v, expected: %v", actualNamespace, expectedNamespace) | |||
| } | |||
|
|
|||
| // Now do it again using -A instead | |||
| testCmd.SetArgs([]string{"-A"}) | |||
There was a problem hiding this comment.
Could we make those tests in a loop like in
for _, arg := range []string { "--all-namespaces", "-A" } {
....
}This would avoid copy & paste code. Same for the other test.
Signed-off-by: Doug Davis <[email protected]>
knative-prow-robot
added
ok-to-test
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: duglin, rhuss The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
the
approved
|
@duglin: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
* Also update E2E test return value on failures Don't rely on "failed" being the default/current state. Bonus: factor out the return code workaround in a separate function. * Document function
…ive#356) - First run serving e2e specific tests - teardown - Setup eventing nightly and run eventing e2e specific tests
-A is my newest favorite kubectl flag, it's so much easier/faster to type
than --all-namespaces. kn users should benefit from it too!
Signed-off-by: Doug Davis [email protected]
/lint
Release Note