Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

service describe command : Move Cluster URL to --verbose from default output #543

Merged
merged 2 commits into from
Dec 10, 2019
Merged

Conversation

itsmurugappan
Copy link
Contributor

Fixes #482

Proposed Changes

  • Show cluster url only in verbose request in service describe command

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Dec 10, 2019
Copy link
Contributor

@knative-prow-robot knative-prow-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@itsmurugappan: 0 warnings.

In response to this:

Fixes #482

Proposed Changes

  • Show cluster url only in verbose request in service describe command

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot
Copy link
Contributor

Hi @itsmurugappan. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot knative-prow-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 10, 2019
@navidshaikh
Copy link
Collaborator

/ok-to-test

@knative-prow-robot knative-prow-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 10, 2019
@knative-metrics-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-knative-client-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/kn/commands/service/describe.go 79.9% 80.0% 0.1

@navidshaikh
Copy link
Collaborator

/test pull-knative-client-integration-tests

boskos

Copy link
Contributor

@rhuss rhuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks !

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 10, 2019
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: itsmurugappan, rhuss

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 10, 2019
@knative-prow-robot knative-prow-robot merged commit 8e010d0 into knative:master Dec 10, 2019
coryrc pushed a commit to coryrc/client that referenced this pull request May 14, 2020
Webhook based API Coverage tool didn't support concurrent updates
for data structures maintained by the resource tree. This causes issues for
tests that run in parellel. This change introduces queue based resource
coverage update by using go routines and channel.

The chnage also fixes a missed case for uint8 type in the resource
tree.
navidshaikh pushed a commit to navidshaikh/client that referenced this pull request Dec 9, 2020
* Update faas plugin to v0.10.0

* Update vendor dir
dsimansk pushed a commit to dsimansk/client that referenced this pull request Dec 10, 2024
…ces/release-v1.15

Update Konflux references
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

service describe: Move 'Cluster' URL to --verbose from default output
6 participants