-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
service describe command : Move Cluster URL to --verbose from default output #543
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@itsmurugappan: 0 warnings.
In response to this:
Fixes #482
Proposed Changes
- Show cluster url only in verbose request in service describe command
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
Hi @itsmurugappan. Thanks for your PR. I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
The following is the coverage report on the affected files.
|
/test pull-knative-client-integration-tests boskos |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks !
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: itsmurugappan, rhuss The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Webhook based API Coverage tool didn't support concurrent updates for data structures maintained by the resource tree. This causes issues for tests that run in parellel. This change introduces queue based resource coverage update by using go routines and channel. The chnage also fixes a missed case for uint8 type in the resource tree.
* Update faas plugin to v0.10.0 * Update vendor dir
…ces/release-v1.15 Update Konflux references
Fixes #482
Proposed Changes