Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cronjob and apiserver source list commands #559

Merged
merged 2 commits into from
Dec 17, 2019

Conversation

navidshaikh
Copy link
Collaborator

@navidshaikh navidshaikh commented Dec 17, 2019

/lint

Proposed Changes

  • - Add kn source cronjob list
  • - Tests for kn source cronjob list
  • - Add kn source apiserver list
  • - Tests for kn source apiserver list
kn source cronjob list
NAME              SCHEDULE      SINK        CONDITIONS   READY   REASON
my-cron-trigger   * * * * */1   svc:mysvc   6 OK / 6     True    
kn source apiserver list -A                                                                       
NAMESPACE   NAME        RESOURCES        SINK        CONDITIONS   READY   REASON
default     k8sevents   Event:v1:false   svc:mysvc   5 OK / 5     True 

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Dec 17, 2019
@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 17, 2019
Copy link
Contributor

@knative-prow-robot knative-prow-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@navidshaikh: 1 warning.

In response to this:

/lint

Proposed Changes

  • - Add kn source cronjob list
  • - Tests for kn source cronjob list
  • - Add kn source apiserver list
  • - Tests for kn source apiserver list
kn source cronjob list
NAME              SCHEDULE      SINK        CONDITIONS   READY   REASON
my-cron-trigger   * * * * */1   svc:mysvc   6 OK / 6     True    

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

pkg/kn/commands/source/cronjob/flags.go Outdated Show resolved Hide resolved
@knative-prow-robot knative-prow-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 17, 2019
@knative-prow-robot knative-prow-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 17, 2019
@knative-metrics-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-knative-client-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/eventing/sources/v1alpha1/apiserver_client.go 100.0% 93.0% -7.0
pkg/eventing/sources/v1alpha1/apiserver_client_mock.go 89.5% 77.3% -12.2
pkg/eventing/sources/v1alpha1/cronjob_client.go 100.0% 91.7% -8.3
pkg/eventing/sources/v1alpha1/cronjob_client_mock.go 89.5% 77.3% -12.2
pkg/kn/commands/source/apiserver/apiserver.go 57.1% 59.1% 1.9
pkg/kn/commands/source/apiserver/flags.go 95.2% 68.1% -27.1
pkg/kn/commands/source/apiserver/list.go Do not exist 78.3%
pkg/kn/commands/source/cronjob/cronjob.go 57.1% 59.1% 1.9
pkg/kn/commands/source/cronjob/flags.go 100.0% 56.2% -43.8
pkg/kn/commands/source/cronjob/list.go Do not exist 78.3%

Copy link
Contributor

@rhuss rhuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks !

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 17, 2019
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: navidshaikh, rhuss

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit 6380fc5 into knative:master Dec 17, 2019
@navidshaikh navidshaikh deleted the pr/sources-listing branch December 17, 2019 16:39
coryrc pushed a commit to coryrc/client that referenced this pull request May 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants