Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vendor serving v0.12.0 #618

Merged
merged 2 commits into from
Jan 22, 2020
Merged

Vendor serving v0.12.0 #618

merged 2 commits into from
Jan 22, 2020

Conversation

navidshaikh
Copy link
Collaborator

  • Vendor serving release v0.12.0
  • Update kn version command to print serving v0.12.0
  • Update latest release e2e tests script to setup serving v0.12.0

@navidshaikh
Vendor serving v0.12.0
da91855 
 - Vendor serving release v0.12.0
 - Update `kn version command` to print serving v0.12.0
 - Update latest release e2e tests script to setup serving v0.12.0
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jan 21, 2020
@knative-prow-robot knative-prow-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jan 21, 2020
@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 21, 2020
maximilien
maximilien approved these changes Jan 21, 2020
View reviewed changes
Copy link
Contributor

@maximilien maximilien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

@knative-prow-robot knative-prow-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Jan 21, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maximilien, navidshaikh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [maximilien,navidshaikh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@maximilien maximilien mentioned this pull request Jan 21, 2020
Merged
rhuss
rhuss reviewed Jan 22, 2020
View reviewed changes
Copy link
Contributor

@rhuss rhuss left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to merge this in a second, I will then start to migrate to v1 API objects and wrap my brain around #462 . But let me try to merge the eventing upgrade first.

@knative-prow-robot knative-prow-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 22, 2020
@rhuss
Copy link
Contributor

rhuss commented Jan 22, 2020

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 22, 2020
@knative-prow-robot knative-prow-robot merged commit 8c417c1 into knative:master Jan 22, 2020
@navidshaikh navidshaikh deleted the pr/serving-v0.12.0 branch January 22, 2020 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhuss rhuss rhuss left review comments

@maximilien maximilien maximilien approved these changes

Assignees

@rhuss rhuss

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@navidshaikh @knative-prow-robot @rhuss @maximilien @googlebot