Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds human-friendly table printing for resource listing #85

Merged
merged 5 commits into from
May 9, 2019
Merged

Adds human-friendly table printing for resource listing #85

merged 5 commits into from
May 9, 2019

Conversation

navidshaikh
Copy link
Collaborator

@knative-prow-robot knative-prow-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 2, 2019
@knative-prow-robot
Copy link
Contributor

Hi @navidshaikh. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@markusthoemmes
Copy link
Contributor

/ok-to-test

@knative-prow-robot knative-prow-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 2, 2019
@cppforlife
Copy link

@navidshaikh i dont see any command using this printers, or did i miss it?

@navidshaikh
Copy link
Collaborator Author

@navidshaikh i dont see any command using this printers, or did i miss it?

@cppforlife : I'll raise separate PRs for commands using this printer.

@navidshaikh
Copy link
Collaborator Author

@cppforlife Here is the new one #90 rebased onto this PR.

sixolet
sixolet suggested changes May 7, 2019
View reviewed changes
Copy link
Contributor

@sixolet sixolet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please copy the license from the k8s originals and also a comment describing where they come from to the top of each of these files?

Other than that good.

navidshaikh added 4 commits May 7, 2019 15:06
@navidshaikh
Adds human-friendly printer
ce85f13 
 All the credits goes to authors of https://github.com/kubernetes/kubernetes/tree/master/pkg/printers
@navidshaikh
Updates the vendor/modules.txt
739c1e9 
 As its updated after running hack/verify-codegen.sh
@navidshaikh
Removes WithKind and WithNamespace printing options
b54e31e 
 Lets start with bare minimum printer
@navidshaikh
Adds licenses
06f8cd0 
 and references the original implementation file link.

 Removes pkg/printers/printers.go
@navidshaikh
Copy link
Collaborator Author

/retest

4 similar comments
@navidshaikh
Copy link
Collaborator Author

/retest

@navidshaikh
Copy link
Collaborator Author

/retest

@navidshaikh
Copy link
Collaborator Author

/retest

@navidshaikh
Copy link
Collaborator Author

/retest

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 9, 2019
@sixolet
Copy link
Contributor

sixolet commented May 9, 2019

/approve
/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label May 9, 2019
@sixolet
Copy link
Contributor

sixolet commented May 9, 2019

/retest

@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: navidshaikh, sixolet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit b6d1bb4 into knative:master May 9, 2019
maximilien pushed a commit to maximilien/client that referenced this pull request May 14, 2019
@navidshaikh @maximilien
Adds human-friendly table printing for resource listing (knative#85)
e7aabc6 
* Adds human-friendly printer

 All the credits goes to authors of https://github.com/kubernetes/kubernetes/tree/master/pkg/printers

* Updates the vendor/modules.txt

 As its updated after running hack/verify-codegen.sh

* Removes WithKind and WithNamespace printing options

 Lets start with bare minimum printer

* Adds licenses

 and references the original implementation file link.

 Removes pkg/printers/printers.go

* Removes unused imports
maximilien pushed a commit to maximilien/client that referenced this pull request May 14, 2019
@navidshaikh @maximilien
Adds human-friendly table printing for resource listing (knative#85)
285a2b2 
* Adds human-friendly printer

 All the credits goes to authors of https://github.com/kubernetes/kubernetes/tree/master/pkg/printers

* Updates the vendor/modules.txt

 As its updated after running hack/verify-codegen.sh

* Removes WithKind and WithNamespace printing options

 Lets start with bare minimum printer

* Adds licenses

 and references the original implementation file link.

 Removes pkg/printers/printers.go

* Removes unused imports
maximilien pushed a commit to maximilien/client that referenced this pull request May 14, 2019
@navidshaikh @maximilien
Adds human-friendly table printing for resource listing (knative#85)
fa9b651 
* Adds human-friendly printer

 All the credits goes to authors of https://github.com/kubernetes/kubernetes/tree/master/pkg/printers

* Updates the vendor/modules.txt

 As its updated after running hack/verify-codegen.sh

* Removes WithKind and WithNamespace printing options

 Lets start with bare minimum printer

* Adds licenses

 and references the original implementation file link.

 Removes pkg/printers/printers.go

* Removes unused imports
coryrc pushed a commit to coryrc/client that referenced this pull request May 14, 2020
@adrcunha @knative-prow-robot
Ignore "Completed" pods when waiting for them to be running (knative#85)
2a22d7a 
Also dump the last checked status of the pods on error, so it's easy to figure out what was wrong.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sixolet sixolet sixolet approved these changes

@evankanderson evankanderson Awaiting requested review from evankanderson

@mattmoor mattmoor Awaiting requested review from mattmoor

Assignees

@sixolet sixolet

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add human friendly printer for resource listing
5 participants
@navidshaikh @knative-prow-robot @markusthoemmes @cppforlife @sixolet