Add support for service url in svc describe output

[hemanrnjn]

Description

Changes

• Added Support for service url display in kn service describe as output format

Reference

Fixes #907

[googlebot]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

---

What to do if you already signed the CLA

Individual signers

• It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

• Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
• The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
• The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

[knative-prow-robot]

@hemanrnjn: 0 warnings.

In response to this:

Description

Changes

Reference

Fixes #

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[knative-prow-robot]

Welcome @hemanrnjn! It looks like this is your first PR to knative/client 🎉

[knative-prow-robot]

Hi @hemanrnjn. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[navidshaikh]

/ok-to-test
/assign

[hemanrnjn]

@googlebot I consent

[hemanrnjn]

@googlebot I consent

[navidshaikh]

@googlebot rescan

[googlebot]

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

[hemanrnjn]

@googlebot I fixed it.

[hemanrnjn]

@googlebot rescan

[googlebot]

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

[hemanrnjn]

/retest

[rhuss]

Thanks, looks good to me !

Some minor requests:

• Please add one line to the CHANGELOG.adoc describing the change.
• I'm not sure if this is easy possible, but it would be awesome if we got get the new option value into kn service describe --help, too. Otherwise it's hard to find out for a user that this option exists. I'm aware that the machinery comes from a dependency, but maybe there's a hook into the help message ?

[navidshaikh]

@hemanrnjn : To add url to allowed formats in flag usage:

command.Flag("output").Usage = fmt.Sprintf("Output format one of %s.", strings.Join(append(machineReadablePrintFlags.AllowedFormats(), "url"), "|"))

Add after line 134 in pkg/kn/commands/service/describe.go.
You can also add a few command examples.

[hemanrnjn]

Thanks, looks good to me !

Some minor requests:

• Please add one line to the CHANGELOG.adoc describing the change.
• I'm not sure if this is easy possible, but it would be awesome if we got get the new option value into kn service describe --help, too. Otherwise it's hard to find out for a user that this option exists. I'm aware that the machinery comes from a dependency, but maybe there's a hook into the help message ?

Both changes done.

[knative-metrics-robot]

The following is the coverage report on the affected files.
Say /test pull-knative-client-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/kn/commands/service/describe.go	82.8%	83.3%	0.5

[hemanrnjn]

/retest

[hemanrnjn]

/retest

[navidshaikh]

/lgtm
/approve

Thank you!

The tests should pass once #920 is in.

[knative-prow-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hemanrnjn, navidshaikh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [navidshaikh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[navidshaikh]

/retest