-
Notifications
You must be signed in to change notification settings - Fork 225
Conversation
6da1161
to
adb6b12
Compare
Flaky #1433 |
/retest |
Flaky #1424
{
"apiVersion": "eventing.knative.dev/v1",
"kind": "Trigger",
"metadata": {
"annotations": {
"eventing.knative.dev/creator": "[email protected]",
"eventing.knative.dev/lastModifier": "[email protected]"
},
"creationTimestamp": "2020-08-27T18:41:07Z",
"generation": 1,
"labels": {
"eventing.knative.dev/broker": "kafkachannel"
},
"name": "trigger",
"namespace": "test-broker-redelivery-kafka-channel-messaging-knative-devn482p",
"resourceVersion": "27965",
"selfLink": "/apis/eventing.knative.dev/v1/namespaces/test-broker-redelivery-kafka-channel-messaging-knative-devn482p/triggers/trigger",
"uid": "a5be8e6a-dc4b-4d13-b38d-9305c9e0937d"
},
"spec": {
"broker": "kafkachannel",
"filter": {},
"subscriber": {
"ref": {
"apiVersion": "v1",
"kind": "Service",
"name": "event-record"
}
}
},
"status": {
"conditions": [
{
"lastTransitionTime": "2020-08-27T18:41:07Z",
"message": "Channel does not have an address.",
"reason": "NoAddress",
"status": "False",
"type": "BrokerReady"
},
{
"lastTransitionTime": "2020-08-27T18:41:07Z",
"status": "Unknown",
"type": "DependencyReady"
},
{
"lastTransitionTime": "2020-08-27T18:41:07Z",
"message": "Channel does not have an address.",
"reason": "NoAddress",
"status": "False",
"type": "Ready"
},
{
"lastTransitionTime": "2020-08-27T18:41:07Z",
"status": "Unknown",
"type": "SubscriberResolved"
},
{
"lastTransitionTime": "2020-08-27T18:41:07Z",
"status": "Unknown",
"type": "SubscriptionReady"
}
],
"observedGeneration": 1
}
} /retest |
/retest |
@@ -42,6 +42,10 @@ type mockConsumerGroupSession struct { | |||
marked bool | |||
} | |||
|
|||
func (m *mockConsumerGroupSession) Commit() { | |||
panic("implement me") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pierDipi was that introduced on 1.27.x APIs ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, they added the ability to manually committing offsets. Commit
performs a blocking synchronous operation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
adb6b12
to
248f676
Compare
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
Signed-off-by: Pierangelo Di Pilato <[email protected]>
248f676
to
bb8b758
Compare
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
Rebased. |
Flaky #1424 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: matzew, pierDipi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative/eventing#3966 is in. 🎉 |
Proposed Changes
Release Note