Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to latest CloudEvent lib #7697

Merged
merged 1 commit into from
Feb 21, 2024
Merged

Conversation

matzew
Copy link
Member

@matzew matzew commented Feb 16, 2024

Fixes #

Proposed Changes

  • 🧹 Bump to latest CloudEvent lib

Pre-review Checklist

  • At least 80% unit test coverage
  • E2E tests for any new behavior
  • Docs PR for any user-facing impact
  • Spec PR for any new API feature
  • Conformance test for any change to the spec

Release Note


Docs

@knative-prow knative-prow bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 16, 2024
@knative-prow knative-prow bot requested review from Cali0707 and lberk February 16, 2024 13:11
@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 16, 2024
Copy link

codecov bot commented Feb 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f8cddc4) 73.98% compared to head (945f001) 73.98%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7697   +/-   ##
=======================================
  Coverage   73.98%   73.98%           
=======================================
  Files         262      262           
  Lines       15178    15178           
=======================================
  Hits        11229    11229           
  Misses       3343     3343           
  Partials      606      606           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matzew
Copy link
Member Author

matzew commented Feb 16, 2024

/test build-tests

Copy link
Member

@Cali0707 Cali0707 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Feb 16, 2024
@matzew
Copy link
Member Author

matzew commented Feb 19, 2024

/test build-tests

@matzew
Copy link
Member Author

matzew commented Feb 19, 2024

\ No newline at end of file
/home/prow/go/src/knative.dev/eventing is out of date. Please run hack/update-codegen.sh
./test/../vendor/knative.dev/hack/presubmit-tests.sh: line 115: warning: command substitution: ignored null byte in input
XML report for _build_tests::Verify_CodeGen written to /logs/artifacts/junit_L1fSjmjP.xml

I can not update codegen: it is up-to-date....

Any idea @pierDipi ?

@matzew matzew force-pushed the cloud_events_2.15.0 branch from 5a20073 to db5efc9 Compare February 20, 2024 09:15
@knative-prow knative-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 20, 2024
@matzew
Copy link
Member Author

matzew commented Feb 20, 2024

Some file in sdk-go seems to cause problems, see:
https://prow.knative.dev/view/gs/knative-prow/pr-logs/pull/knative_eventing/7697/build-tests_eventing_main/1759869543099928576#1:build-log.txt%3A404-405

Will ping sdk-go about this new "file".

Signed-off-by: Matthias Wessendorf <[email protected]>
@matzew matzew force-pushed the cloud_events_2.15.0 branch from db5efc9 to 945f001 Compare February 21, 2024 16:05
Copy link
Member

@Cali0707 Cali0707 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Feb 21, 2024
Copy link

knative-prow bot commented Feb 21, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cali0707, matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 8393b3e into knative:main Feb 21, 2024
35 of 39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants