Skip to content

Commit

Permalink
Bump k8s min k8s version to 1.19 (#2157)
Browse files Browse the repository at this point in the history
* Bump min k8s version to 1.19

This patch bumps min k8s version to 1.19

Pelase also see https://github.com/knative/community/blob/main/mechanics/RELEASE-VERSIONING-PRINCIPLES.md#knative-serving-version-table

* Fix link

* Update link to mkdoc's
  • Loading branch information
nak3 authored Jun 15, 2021
1 parent 192b0c9 commit 77ff8d9
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 10 deletions.
5 changes: 2 additions & 3 deletions version/version.go
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,8 @@ const (

// NOTE: If you are changing this line, please also update the minimum kubernetes
// version listed here:
// https://github.com/knative/docs/blob/main/docs/install/any-kubernetes-cluster.md#before-you-begin
// https://github.com/knative/docs/blob/main/docs/install/knative-with-operators.md#prerequisites
defaultMinimumVersion = "v1.18.0"
// https://github.com/knative/docs/blob/mkdocs/docs/snippets/prerequisites.md
defaultMinimumVersion = "v1.19.0"
)

func getMinimumVersion() string {
Expand Down
14 changes: 7 additions & 7 deletions version/version_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -41,13 +41,13 @@ func TestVersionCheck(t *testing.T) {
wantError bool
}{{
name: "greater version (patch)",
actualVersion: &testVersioner{version: "v1.18.2"},
actualVersion: &testVersioner{version: "v1.19.2"},
}, {
name: "greater version (patch), no v",
actualVersion: &testVersioner{version: "1.18.2"},
actualVersion: &testVersioner{version: "1.19.2"},
}, {
name: "greater version (patch), pre-release",
actualVersion: &testVersioner{version: "1.18.2-kpn-065dce"},
actualVersion: &testVersioner{version: "1.19.2-kpn-065dce"},
}, {
name: "greater version (patch), pre-release, envvar override",
actualVersion: &testVersioner{version: "1.15.11-kpn-065dce"},
Expand All @@ -58,16 +58,16 @@ func TestVersionCheck(t *testing.T) {
versionOverride: "1.15.11-0",
}, {
name: "greater version (minor)",
actualVersion: &testVersioner{version: "v1.18.0"},
actualVersion: &testVersioner{version: "v1.19.0"},
}, {
name: "same version",
actualVersion: &testVersioner{version: "v1.18.0"},
actualVersion: &testVersioner{version: "v1.19.0"},
}, {
name: "same version with build",
actualVersion: &testVersioner{version: "v1.18.0+k3s.1"},
actualVersion: &testVersioner{version: "v1.19.0+k3s.1"},
}, {
name: "same version with pre-release",
actualVersion: &testVersioner{version: "v1.18.0-k3s.1"},
actualVersion: &testVersioner{version: "v1.19.0-k3s.1"},
}, {
name: "smaller version",
actualVersion: &testVersioner{version: "v1.14.3"},
Expand Down

0 comments on commit 77ff8d9

Please sign in to comment.