Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switching Boskos to deployment, as well as removing persistent volume #1584

Merged
merged 1 commit into from
Dec 12, 2019

Conversation

chaodaiG
Copy link
Contributor

@chaodaiG chaodaiG commented Dec 11, 2019

This change is to make our Boskos deployment consistent with upstream, almost a mirror of kubernetes/test-infra#13594

Also copied from the PR above:

kubectl delete -n test-pods statefulset boskos
# wait for boskos-0 pod to be gone in test-pods ns
kubectl delete -n test-pods pv boskos-storage
kubectl apply -f ci/prow/deployments/boskos_deployment.yaml

Part of: #1533

/cc @yt3liu
/cc @sebastienvas

This change is to make our Boskos deployment consistent with upstream, almost a mirror of kubernetes/test-infra#13594
@knative-prow-robot
Copy link
Collaborator

@chaodaiG: GitHub didn't allow me to request PR reviews from the following users: sebastienvas.

Note that only knative members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

This change is to make our Boskos deployment consistent with upstream, almost a mirror of kubernetes/test-infra#13594

Part of: #1533

/cc @yt3liu
/cc @sebastienvas

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot knative-prow-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 11, 2019
@chaodaiG
Copy link
Contributor Author

/hold
So that this PR doesn't get merged at a wrong time

@knative-prow-robot knative-prow-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 11, 2019
@yt3liu
Copy link
Contributor

yt3liu commented Dec 11, 2019

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 11, 2019
@knative-prow-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adrcunha, chaodaiG

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@chaodaiG
Copy link
Contributor Author

/hold cancel

@knative-prow-robot knative-prow-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 12, 2019
@knative-prow-robot knative-prow-robot merged commit a00f8b8 into knative:master Dec 12, 2019
@chaodaiG chaodaiG deleted the boskos_dep branch March 19, 2020 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants