Skip to content
This repository has been archived by the owner on Dec 15, 2021. It is now read-only.

Fix/update missed release parameter #261

Merged
merged 1 commit into from
Mar 16, 2021

Conversation

RichieEscarez
Copy link
Contributor

This value exists as a "default/fallback" value and is used in the right-side nav menu and the branch shortcode:

https://knative.dev/docs/smoketest/#install-version-numbers-and-clone-branch-commands

@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Mar 6, 2021
@knative-prow-robot knative-prow-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 6, 2021
Base automatically changed from master to main March 8, 2021 17:38
@omerbensaadon
Copy link

I don't fully understand what this changes...

In the right-side panel, when I hover over "Edit this page" it looks like it is currently pointing at the release-0.21 branch.

What does this change?

Copy link

@omerbensaadon omerbensaadon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Don't understand what this does but our latest release is 0.21 so...

Is there a way to automate this update? (assuming it is important) CC: @evankanderson

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 16, 2021
@RichieEscarez RichieEscarez added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 16, 2021
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: omerbensaadon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit 5c2bbae into knative:main Mar 16, 2021
knative-prow-robot pushed a commit that referenced this pull request Mar 23, 2021
* disable live reload and fix too many open files error (#233)

* Add an update-codegen to regenerate the static redirects. (#239)

* Add an update-codegen to regenerate the static redirects.

Also fix a bug in redir-gen.

* Add trailing newline

* Fix missing continue

* update docs build for 0.19 (#240)

* Update DEVELOPMENT.md (#241)

* Update DEVELOPMENT.md

Document dependency on Hugo

* Update DEVELOPMENT.md

Point to docsy's recommended Hugo version.

Co-authored-by: RichieEscarez <[email protected]>

Co-authored-by: RichieEscarez <[email protected]>

* Update build scripts to build from any named docs fork (#242)

* make /community optional - default to knative repo

* move webhook payload output to bottom of log

* add logic to determine and use repo name of any fork

* extract and use repo name from specified fork

* Avoid Host key verification failed.

* Add net-ingressv2 golang redirect (#244)

* Fix static HTML build (#245)

dont add HUGO server flags unless you enable the server [localbuild.sh -s (true/reload)]

* add version 0.20.0 to docs build (#247)

* normal size nav text (#248)

* Added control protocol redirect (#254)

Signed-off-by: Francesco Guardiani <[email protected]>

* fix typo (#249)

* add version 0.21.0 to docs build (#256)

* add version 0.21.0 to docs build

* trigger build

* trigger build back

* Redirect contributing URL to the docs website (#257)

* Remove README->index renames (#259)

* Add knative.dev/specs golang redirect (#258)

* Add knative.dev/specs golang redirect

* squash

* search/replace master with main (#263)

* Add Google Analytics tracking ID (#262)

* new partial for adding 2nd GA id

* force both IDs and ensure feedback buttons work

* add: Redirects for various knative-sandbox plugin repos (#251)

* Regenerate redirects to point at main (#265)

* Run github.com/client9/misspell (#266)

Signed-off-by: Knative Automation <[email protected]>

* Fix/update missed release parameter (#261)

* Add future Docs release owners as Approvers (#264)

* Update development instructions with netlify info (#269)

* Copy down notes from Slack

* edits

Co-authored-by: RichieEscarez <[email protected]>

* Update to latest version of Hugo from ~6 month old version (#270)

* Resolved issue where files named "index.md" had incorrect file paths (#272)

relative to local links

* Add autogenerated imports (#274)

Co-authored-by: Evan Anderson <[email protected]>
Co-authored-by: Sameer Vohra <[email protected]>
Co-authored-by: Kenjiro Nakayama <[email protected]>
Co-authored-by: Francesco Guardiani <[email protected]>
Co-authored-by: Carlos Santana <[email protected]>
Co-authored-by: tayarani <[email protected]>
Co-authored-by: Roland Huß <[email protected]>
Co-authored-by: Markus Thömmes <[email protected]>
Co-authored-by: knative-automation <[email protected]>
Co-authored-by: Mike Petersen <[email protected]>
knative-prow-robot pushed a commit that referenced this pull request May 11, 2021
* disable live reload and fix too many open files error (#233)

* Add an update-codegen to regenerate the static redirects. (#239)

* Add an update-codegen to regenerate the static redirects.

Also fix a bug in redir-gen.

* Add trailing newline

* Fix missing continue

* update docs build for 0.19 (#240)

* Update DEVELOPMENT.md (#241)

* Update DEVELOPMENT.md

Document dependency on Hugo

* Update DEVELOPMENT.md

Point to docsy's recommended Hugo version.

Co-authored-by: RichieEscarez <[email protected]>

Co-authored-by: RichieEscarez <[email protected]>

* Update build scripts to build from any named docs fork (#242)

* make /community optional - default to knative repo

* move webhook payload output to bottom of log

* add logic to determine and use repo name of any fork

* extract and use repo name from specified fork

* Avoid Host key verification failed.

* Add net-ingressv2 golang redirect (#244)

* Fix static HTML build (#245)

dont add HUGO server flags unless you enable the server [localbuild.sh -s (true/reload)]

* add version 0.20.0 to docs build (#247)

* normal size nav text (#248)

* Added control protocol redirect (#254)

Signed-off-by: Francesco Guardiani <[email protected]>

* fix typo (#249)

* add version 0.21.0 to docs build (#256)

* add version 0.21.0 to docs build

* trigger build

* trigger build back

* Redirect contributing URL to the docs website (#257)

* Remove README->index renames (#259)

* Add knative.dev/specs golang redirect (#258)

* Add knative.dev/specs golang redirect

* squash

* search/replace master with main (#263)

* Add Google Analytics tracking ID (#262)

* new partial for adding 2nd GA id

* force both IDs and ensure feedback buttons work

* add: Redirects for various knative-sandbox plugin repos (#251)

* Regenerate redirects to point at main (#265)

* Run github.com/client9/misspell (#266)

Signed-off-by: Knative Automation <[email protected]>

* Fix/update missed release parameter (#261)

* Add future Docs release owners as Approvers (#264)

* Update development instructions with netlify info (#269)

* Copy down notes from Slack

* edits

Co-authored-by: RichieEscarez <[email protected]>

* Update to latest version of Hugo from ~6 month old version (#270)

* Resolved issue where files named "index.md" had incorrect file paths (#272)

relative to local links

* Add autogenerated imports (#274)

* Bump y18n from 4.0.0 to 4.0.1 (#279)

Bumps [y18n](https://github.com/yargs/y18n) from 4.0.0 to 4.0.1.
- [Release notes](https://github.com/yargs/y18n/releases)
- [Changelog](https://github.com/yargs/y18n/blob/master/CHANGELOG.md)
- [Commits](https://github.com/yargs/y18n/commits)

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Update OWNERS_ALIASES to match autogen in community (#282)

* add instructions for cutting a release (#284)

* Fix spaces in command (#285)

* Releasing 0.22 (#287)

* Fixed spacing on code blocks (#289)

* Don't build elections content into the website (#291)

* Enable asciidoctor in Netlify builds (#292)

* Enable asciidoctor in Netlify builds

* Don't build elections content into the website

* Update knative/community files (#277)

Signed-off-by: Knative Automation <[email protected]>

* Update knative/community files (#293)

Signed-off-by: Knative Automation <[email protected]>

* Redirect serving spec to specs repo (#290)

* Enable new "help" section and fix  a few things (#288)

* new how to docs guides section

* stop ignoring links in _index.md

* add table formatting

* move Dev instructions

* update previous section name

* revert table css

* Remove golang module and build scripts from hugo build (#295)

* Manually update from /community

Copied from https://github.com/knative/community/blob/main/OWNERS_ALIASES

Co-authored-by: Evan Anderson <[email protected]>
Co-authored-by: Sameer Vohra <[email protected]>
Co-authored-by: Kenjiro Nakayama <[email protected]>
Co-authored-by: Francesco Guardiani <[email protected]>
Co-authored-by: Carlos Santana <[email protected]>
Co-authored-by: tayarani <[email protected]>
Co-authored-by: Roland Huß <[email protected]>
Co-authored-by: Markus Thömmes <[email protected]>
Co-authored-by: knative-automation <[email protected]>
Co-authored-by: Mike Petersen <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Omer B <[email protected]>
Co-authored-by: Ashleigh Brennan <[email protected]>
knative-prow-robot pushed a commit that referenced this pull request May 20, 2021
* disable live reload and fix too many open files error (#233)

* Add an update-codegen to regenerate the static redirects. (#239)

* Add an update-codegen to regenerate the static redirects.

Also fix a bug in redir-gen.

* Add trailing newline

* Fix missing continue

* update docs build for 0.19 (#240)

* Update DEVELOPMENT.md (#241)

* Update DEVELOPMENT.md

Document dependency on Hugo

* Update DEVELOPMENT.md

Point to docsy's recommended Hugo version.

Co-authored-by: RichieEscarez <[email protected]>

Co-authored-by: RichieEscarez <[email protected]>

* Update build scripts to build from any named docs fork (#242)

* make /community optional - default to knative repo

* move webhook payload output to bottom of log

* add logic to determine and use repo name of any fork

* extract and use repo name from specified fork

* Avoid Host key verification failed.

* Add net-ingressv2 golang redirect (#244)

* Fix static HTML build (#245)

dont add HUGO server flags unless you enable the server [localbuild.sh -s (true/reload)]

* add version 0.20.0 to docs build (#247)

* normal size nav text (#248)

* Added control protocol redirect (#254)

Signed-off-by: Francesco Guardiani <[email protected]>

* fix typo (#249)

* add version 0.21.0 to docs build (#256)

* add version 0.21.0 to docs build

* trigger build

* trigger build back

* Redirect contributing URL to the docs website (#257)

* Remove README->index renames (#259)

* Add knative.dev/specs golang redirect (#258)

* Add knative.dev/specs golang redirect

* squash

* search/replace master with main (#263)

* Add Google Analytics tracking ID (#262)

* new partial for adding 2nd GA id

* force both IDs and ensure feedback buttons work

* add: Redirects for various knative-sandbox plugin repos (#251)

* Regenerate redirects to point at main (#265)

* Run github.com/client9/misspell (#266)

Signed-off-by: Knative Automation <[email protected]>

* Fix/update missed release parameter (#261)

* Add future Docs release owners as Approvers (#264)

* Update development instructions with netlify info (#269)

* Copy down notes from Slack

* edits

Co-authored-by: RichieEscarez <[email protected]>

* Update to latest version of Hugo from ~6 month old version (#270)

* Resolved issue where files named "index.md" had incorrect file paths (#272)

relative to local links

* Add autogenerated imports (#274)

* Bump y18n from 4.0.0 to 4.0.1 (#279)

Bumps [y18n](https://github.com/yargs/y18n) from 4.0.0 to 4.0.1.
- [Release notes](https://github.com/yargs/y18n/releases)
- [Changelog](https://github.com/yargs/y18n/blob/master/CHANGELOG.md)
- [Commits](https://github.com/yargs/y18n/commits)

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Update OWNERS_ALIASES to match autogen in community (#282)

* add instructions for cutting a release (#284)

* Fix spaces in command (#285)

* Releasing 0.22 (#287)

* Fixed spacing on code blocks (#289)

* Don't build elections content into the website (#291)

* Enable asciidoctor in Netlify builds (#292)

* Enable asciidoctor in Netlify builds

* Don't build elections content into the website

* Update knative/community files (#277)

Signed-off-by: Knative Automation <[email protected]>

* Update knative/community files (#293)

Signed-off-by: Knative Automation <[email protected]>

* Redirect serving spec to specs repo (#290)

* Enable new "help" section and fix  a few things (#288)

* new how to docs guides section

* stop ignoring links in _index.md

* add table formatting

* move Dev instructions

* update previous section name

* revert table css

* Remove golang module and build scripts from hugo build (#295)

* Run github.com/client9/misspell (#298)

Signed-off-by: Knative Automation <[email protected]>

* Add knative-release-leads to OWNERS (#302)

* upgrade to latest dependencies (#301)

Signed-off-by: Knative Automation <[email protected]>

* update website for v0.23 (#303)

Signed-off-by: Carlos Santana <[email protected]>

* Update knative/community files (#300)

Signed-off-by: Knative Automation <[email protected]>

Co-authored-by: RichieEscarez <[email protected]>
Co-authored-by: Evan Anderson <[email protected]>
Co-authored-by: Sameer Vohra <[email protected]>
Co-authored-by: Kenjiro Nakayama <[email protected]>
Co-authored-by: Francesco Guardiani <[email protected]>
Co-authored-by: tayarani <[email protected]>
Co-authored-by: Roland Huß <[email protected]>
Co-authored-by: Markus Thömmes <[email protected]>
Co-authored-by: knative-automation <[email protected]>
Co-authored-by: Mike Petersen <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Omer B <[email protected]>
Co-authored-by: Ashleigh Brennan <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants