Skip to content
This repository has been archived by the owner on Dec 15, 2021. It is now read-only.

override pre tag - fix hor scrollbar overlap #27

Merged
merged 1 commit into from
Apr 8, 2019

Conversation

RichieEscarez
Copy link
Contributor

Add padding to the bottom of <pre> tags to resolve display issue in MacOS and Chrome (prevent horizontal scroll bar from overlapping and covering code)

fixes knative/docs#1150

@knative-prow-robot knative-prow-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 6, 2019
@RichieEscarez
Copy link
Contributor Author

scroll fix

Ive tested this by setting my Mac to the known issue settings and the extra padding in the CSS appears to resolve the issue.

@samodell
Copy link
Contributor

samodell commented Apr 8, 2019

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 8, 2019
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RichieEscarez, samodell

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [RichieEscarez,samodell]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit f0da156 into knative:master Apr 8, 2019
@RichieEscarez RichieEscarez deleted the pretagcss branch April 23, 2019 22:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scrollbar in codeblock renders over and covers the content
4 participants