-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Installation issue, directly related to RcppAnnoy 0.0.15 vs the previous 0.0.14 #10
Comments
That is ... pretty long and detailed. One issue is
which comes from sourcing the same header multiple times and not having the functions |
I'm seeing an error on Debian in my Docker image also:
|
I was wondering when the ripple effects of jlmelville/uwot#50 would eventually reach BiocNeighbors. I must say that this entire affair has been rather... Annoy-ing. (Ho ho ho. I've been wanting to say that since this entire business started.) Seems to be an easy enough fix at the RcppAnnoy level. If we get the patch onto CRAN in a timely manner, no change should be needed in BiocNeighbors or its downstream packages. Otherwise I guess I could divert all the Annoy code to point to, say, HNSW. I'd rather not, though maybe I'll have to do it if things like eddelbuettel/rcppannoy#56 are blocking updates to CRAN. If you urgently need a new installation, just pull RcppAnnoy from https://github.com/LTLA/RcppAnnoy and override the CRAN version for the time being. |
Just to confirm: you tested my (off-the cuff) suggestion to make the functions |
Thanks @eddelbuettel and @LTLA. In case anyone else comes across this issue, reinstalling RcppAnnoy v0.0.14 keeps BiocNeighbors working in the meantime:
|
@eddelbuettel Yes, that's right. I was also hoping that the "Fixes" keyword would close this issue, but apparently GitHub isn't that smart. |
I am away at a workshop but I plan to create a 0.0.15.1 version that you can get from a drat repo. Maybe take a day or two for me to get to it... |
0.0.16 is now in incoming at CRAN and should fix it for good. |
… file? Related to knncolle/BiocNeighbors#10 Former-commit-id: 1c1485d79a76d72cbf7c3ea4e68be9b34e7f8e08 [formerly 25f0f8c] Former-commit-id: 2f8e6f6fab07f537d28965cf8187bb1b895c8fe2
… file? Related to knncolle/BiocNeighbors#10 Former-commit-id: 1c1485d79a76d72cbf7c3ea4e68be9b34e7f8e08 [formerly 25f0f8c] Former-commit-id: 2f8e6f6fab07f537d28965cf8187bb1b895c8fe2 Former-commit-id: 3c3a855
Hi,
I noticed that
RcppAnnoy
just changed from 0.0.14 to 0.0.15 and as this is used byBiocNeighbors
while compiling, there's now an installation issue that was absent before. I have no idea howRcppAnnoy
works but maybe you do. Maybe this involves an update onBiocNeighbors
or fixing something inRcppAnnoy
.Best,
Leo
Remote (shinyapps.io)
Below is the installation log from shinyapps.io where I saw the error (30 min ago, 2 hours ago this was not the case). That is, when trying to update https://jhubiostatistics.shinyapps.io/spatialLIBD/.
Reproduce locally (macOS)
I see at http://bioconductor.org/checkResults/release/bioc-LATEST/BiocNeighbors/ that the latest BioC build report hasn't picked this up yet. In any case, I can also reproduce this locally on my macOS:
Install
RcppAnnoy
0.0.14then try again to install
BiocNeighbors
from source:R session information (macOS)
R session information (shinyapps)
Here's the full session information from the last successful build at shinyapps.io. Note that
spatialLIBD
doesn't actually loadRcppAnnoy
(it's on the suggests forBiocNeighbor
). So we can't see the version number there.The text was updated successfully, but these errors were encountered: