Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add range support #121

Closed
wants to merge 1 commit into from
Closed

add range support #121

wants to merge 1 commit into from

Conversation

wcttmf
Copy link

@wcttmf wcttmf commented Mar 27, 2019

here is some test:
curl http://localhost:3000/package.json -i -H "Range: bytes=0-50, 100-150"

HTTP/1.1 200 OK
Accept-Ranges: bytes
Last-Modified: Wed, 27 Mar 2019 11:20:08 GMT
Cache-Control: max-age=0
Content-Type: multipart/byteranges; boundary=--------------------------674091310343117359970110
Content-Length: 375
Date: Wed, 27 Mar 2019 11:45:17 GMT
Connection: keep-alive

--------------------------674091310343117359970110
Content-Type: .json
Content-Range: bytes 0-50/1149

{
  "name": "koa-send",
  "description": "Transfer
--------------------------674091310343117359970110
Content-Type: .json
Content-Range: bytes 100-150/1149

ersion": "5.0.0",
  "keywords": [
    "koa",
    "f
--------------------------674091310343117359970110--

@niftylettuce
Copy link
Contributor

Can you please resolve conflicts and then ping me back?

Copy link
Member

@3imed-jaberi 3imed-jaberi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lsy1458845893, can you resolve the conflicts !!

@Meleeman01 Meleeman01 mentioned this pull request Dec 9, 2021
@mreinstein
Copy link

Is this still wanted? I can submit a fresh PR with the conflicts resolved.

@wcttmf wcttmf closed this by deleting the head repository Sep 20, 2022
@mreinstein
Copy link

I guess the original author gave up on this PR. Is this something that koajs/send would accept? I'm happy to submit a new PR with the merge conflicts resolved if that's helpful. @3imed-jaberi @niftylettuce

@mreinstein
Copy link

Maybe it is better to just leave this alone, and point people to the koa-range middleware rather than baking this into koa-send ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants