Merge pull request rubocop#1131 from jamiemccarthy/jm-unique-validati…

…on-fix [Fix rubocop#1130] Fix crash for Rails/UniqueValidationWithoutIndex with bare validate
koic · Sep 25, 2023 · 7a0208b · 7a0208b
2 parents d3117ff + bd4f92b
commit 7a0208b
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 1 deletion.
diff --git a/changelog/fix_bug_unique_validation_without_index.md b/changelog/fix_bug_unique_validation_without_index.md
@@ -0,0 +1 @@
+* [#1130](https://github.com/rubocop/rubocop-rails/issues/1130): Fix crash for `Rails/UniqueValidationWithoutIndex` with bare validate. ([@jamiemccarthy][])
diff --git a/lib/rubocop/cop/rails/unique_validation_without_index.rb b/lib/rubocop/cop/rails/unique_validation_without_index.rb
@@ -125,7 +125,7 @@ def class_node(node)
 
         def uniqueness_part(node)
           pairs = node.arguments.last
-          return unless pairs.hash_type?
+          return unless pairs&.hash_type?
 
           pairs.each_pair.find do |pair|
             next unless pair.key.sym_type? && pair.key.value == :uniqueness

diff --git a/spec/rubocop/cop/rails/unique_validation_without_index_spec.rb b/spec/rubocop/cop/rails/unique_validation_without_index_spec.rb
@@ -60,6 +60,24 @@ class User
           end
         RUBY
       end
+
+      it 'ignores a bare validates directive by itself' do
+        expect_no_offenses(<<~RUBY)
+          class User
+            validates
+          end
+        RUBY
+      end
+
+      it 'ignores a bare validates directive among others' do
+        expect_no_offenses(<<~RUBY)
+          class User
+            validates
+            after_commit :foo
+            def foo; true; end
+          end
+        RUBY
+      end
     end
 
     context 'when the table has an index but it is not unique' do