Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update base kokkos version to 4.4.01 #175

Merged
merged 3 commits into from
Oct 15, 2024
Merged

Update base kokkos version to 4.4.01 #175

merged 3 commits into from
Oct 15, 2024

Conversation

yasahi-hpc
Copy link
Collaborator

improves #85

In this PR, update the minimal Kokkos version to 4.4.

  • update submodules
  • update Kokkos minimal version to 4.4 in CMakeLists.txt
  • update README.md and docs

@yasahi-hpc yasahi-hpc self-assigned this Oct 15, 2024
@yasahi-hpc yasahi-hpc added the enhancement New feature or request label Oct 15, 2024
@yasahi-hpc yasahi-hpc changed the title Update kokkos version Update base kokkos version to 4.4.01 Oct 15, 2024
@yasahi-hpc yasahi-hpc requested a review from tpadioleau October 15, 2024 05:03
tpadioleau
tpadioleau approved these changes Oct 15, 2024
View reviewed changes
Copy link
Member

@tpadioleau tpadioleau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok for me

@yasahi-hpc
Copy link
Collaborator Author

Thanks!
I will merge this and then update #171

@yasahi-hpc yasahi-hpc merged commit da02175 into kokkos:main Oct 15, 2024
19 of 20 checks passed
@yasahi-hpc yasahi-hpc deleted the update-kokkos-version branch October 15, 2024 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tpadioleau tpadioleau tpadioleau approved these changes

Assignees

@yasahi-hpc yasahi-hpc

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yasahi-hpc @tpadioleau