Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update code to work with newer versions of Kokkos develop #40

Closed
nphtan opened this issue Jun 6, 2022 · 1 comment · Fixed by #41
Closed

Update code to work with newer versions of Kokkos develop #40

nphtan opened this issue Jun 6, 2022 · 1 comment · Fixed by #41
Assignees
Labels
bug Something isn't working

Comments

@nphtan
Copy link
Collaborator

nphtan commented Jun 6, 2022

A recent commit (4dced25118a9fa5021de7e8cf076154cf9681e26) changed the names for some of the internal OpenMP files. Kokkos resilience will need some updates to rename a few header includes.

  • Kokkos_OpenMP_Exec -> Kokkos_OpenMP_Instance
  • Kokkos::Impl::OpenMPExec -> Kokkos::Impl::OpenMPInternal

There are also some issues in some of the tests (TestOpenMPResilientExecution.cpp). I don't see any recent changes that could have caused the problem other than some magic number changes.

/home/nphtan/kokkos/build/install/include/impl/Kokkos_Profiling_Interface.hpp(126): error: class "Kokkos::Tools::Experimental::DeviceTypeTraitsKokkosResilience::ResOpenMP" has no member "device_id"
(DeviceTypeTraits::device_id(space)
^
detected during:
instantiation of "uint32_t={__uint32_t={unsigned int}} Kokkos::Tools::Experimental::device_id(const ExecutionSpace &) [with ExecutionSpace=KokkosResilience::ResOpenMP]" at line 371 of "/home/nphtan/kokkos/build/install/include/impl/Kokkos_Tools_Generic.hpp"
instantiation of "void Kokkos::Tools::Impl::begin_parallel_for(ExecPolicy &, FunctorType &, const std::string &, uint64_t={__uint64_t={unsigned long}} &) [with ExecPolicy=range_policy, FunctorType=const lambda ->void]" at line 162 of "/home/nphtan/kokkos/build/install/include/Kokkos_Parallel.hpp"
instantiation of "void Kokkos::parallel_for(const ExecPolicy &, const FunctorType &, const std::string &, std::enable_if_t<Kokkos::is_execution_policy::value, void> *) [with ExecPolicy=range_policy, FunctorType=lambda ->void]" at line 113 of "/home/nphtan/kokkos-resilience/tests/TestOpenMPResilientExecution.cpp"

compilation aborted for /home/nphtan/kokkos-resilience/tests/TestOpenMPResilientExecution.cpp (code 2)
make[2]: *** [tests/CMakeFiles/resilience_tests.dir/build.make:134: tests/CMakeFiles/resilience_tests.dir/TestOpenMPResilientExecution.cpp.o] Error 2
make[1]: *** [CMakeFiles/Makefile2:573: tests/CMakeFiles/resilience_tests.dir/all] Error 2
make: *** [Makefile:160: all] Error 2

@nphtan nphtan added the bug Something isn't working label Jun 6, 2022
@nmm0
Copy link
Contributor

nmm0 commented Jun 7, 2022

We were able to reproduce this (and a few other issues due to some internal changes Kokkos made), we are working on a fix

@ElisabethGiem ElisabethGiem linked a pull request Jun 8, 2022 that will close this issue
nmm0 added a commit that referenced this issue Jun 6, 2023
…incomplete types. In the future we should just use nlohmann_json types
@nmm0 nmm0 closed this as completed in #41 Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants