Intel 18 Error: "simd pragma has been deprecated"

[ndellingwood]

Reported by Jenkins:

/home/jenkins/bowman/workspace/Kokkos_SLURM_inner_test/core/unit_test/TestCompilerMacros.hpp(88): error #3948: simd pragma has been deprecated, and will be removed in a future release.  Please refer to release notes for details and recommended alternatives
      #pragma simd
              ^
          detected during:
            instantiation of "std::enable_if<std::is_same<TagType, void>::value, void>::type Kokkos::Impl::ParallelFor<FunctorType, Kokkos::RangePolicy<Traits...>, Kokkos::OpenMP>::exec_range<TagType>(const FunctorType &, Kokkos::Impl::ParallelFor<FunctorType, Kokkos::RangePolicy<Traits...>, Kokkos::OpenMP>::Member, Kokkos::Impl::ParallelFor<FunctorType, Kokkos::RangePolicy<Traits...>, Kokkos::OpenMP>::Member) [with FunctorType=TestCompilerMacros::AddFunctor<Kokkos::OpenMP>,
                      Traits=<Kokkos::OpenMP>, TagType=void]" at line 124 of "/home/jenkins/bowman/workspace/Kokkos_SLURM_inner_test/core/src/OpenMP/Kokkos_OpenMP_Parallel.hpp"
            instantiation of "void Kokkos::Impl::ParallelFor<FunctorType, Kokkos::RangePolicy<Traits...>, Kokkos::OpenMP>::execute() const [with FunctorType=TestCompilerMacros::AddFunctor<Kokkos::OpenMP>, Traits=<Kokkos::OpenMP>]" at line 224 of "/home/jenkins/bowman/workspace/Kokkos_SLURM_inner_test/core/src/Kokkos_Parallel.hpp"
            instantiation of "void Kokkos::parallel_for(size_t={unsigned long}, const FunctorType &, const std::string &) [with FunctorType=TestCompilerMacros::AddFunctor<Kokkos::OpenMP>]" at line 104
            instantiation of "bool TestCompilerMacros::Test<DeviceType>() [with DeviceType=Kokkos::OpenMP]" at line 115

compilation aborted for /home/jenkins/bowman/workspace/Kokkos_SLURM_inner_test/core/unit_test/openmp/TestOpenMP_Init.cpp (code 2)

[ndellingwood]

kokkos/core/unit_test/TestCompilerMacros.hpp

Lines 87 to 89 in f890812

	#ifdef KOKKOS_ENABLE_PRAGMA_SIMD
	#pragma simd
	#endif

[ibaned]

@nmhamster @crtrott

[ibaned]

Despite what the error message says, a quick search of the release notes doesn't give clear guidance on this. My guess is that #pragma omp simd is the replacement...

[ndellingwood]

Here's a reference to intel 18 c++ release notes and intel 17 c++ release notes, at a quick scan I didn't see anything about this being deprecated either

[crtrott]

I actually have already a fix for this on bowman. Just didn't submit it yet because when I wrote it the compute nodes were down to run the test.