Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not pass arch flags to the linker with no rdc #3846

Merged
merged 5 commits into from
Mar 12, 2021
Merged

Do not pass arch flags to the linker with no rdc #3846

merged 5 commits into from
Mar 12, 2021

Conversation

dalg24
Copy link
Member

@dalg24 dalg24 commented Mar 11, 2021

No description provided.

@dalg24 dalg24 requested a review from Rombur March 11, 2021 22:08
dalg24
dalg24 commented Mar 11, 2021
View reviewed changes
cmake/kokkos_arch.cmake
UNSET(KOKKOS_ARCH_${ARCH} PARENT_SCOPE)
ELSE()
SET(KOKKOS_AMDGPU_ARCH_FLAG ${FLAG} PARENT_SCOPE)
GLOBAL_APPEND(KOKKOS_AMDGPU_OPTIONS "${AMDGPU_ARCH_FLAG}=${FLAG}")
IF(KOKKOS_ENABLE_HIP)
IF(KOKKOS_ENABLE_HIP_RELOCATABLE_DEVICE_CODE)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the important bit

@dalg24
Copy link
Member Author

dalg24 commented Mar 11, 2021 

clang-11: error: argument unused during compilation: '-fno-gpu-rdc' [-Werror,-Wunused-command-line-argument]

masterleinad
masterleinad approved these changes Mar 11, 2021
View reviewed changes
Copy link
Contributor

@masterleinad masterleinad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is analogous to what we are doing for CUDA so this looks OK to me.

@dalg24
Copy link
Member Author

dalg24 commented Mar 11, 2021

clang-11: error: argument unused during compilation: '-fno-gpu-rdc' [-Werror,-Wunused-command-line-argument]

I don't get the warning with ROCm 3.9

@dalg24
Copy link
Member Author

dalg24 commented Mar 11, 2021

Let's revert 3ea7048 and re-apply whenever we update the ROCm version in our CI containers.

@crtrott crtrott merged commit e74d9d2 into kokkos:develop Mar 12, 2021
@crtrott crtrott deleted the cleanup_kokkos_arch_cmake branch March 12, 2021 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crtrott crtrott crtrott approved these changes

@masterleinad masterleinad masterleinad approved these changes

@Rombur Rombur Awaiting requested review from Rombur

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dalg24 @masterleinad @crtrott