Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use secure enclave public key, tweaks #35

Merged

Conversation

James-Pickett
Copy link
Contributor

@James-Pickett James-Pickett commented Dec 15, 2023

updates secure enclave code to return public key instead of hash

releates to kolide/launcher#1514

Copy link

@RebeccaMahany RebeccaMahany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- we should probably bump the major version after merge since this changes the signatures for New and CreateKey?

Copy link
Contributor

@directionless directionless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is okay

@James-Pickett James-Pickett merged commit db516b7 into kolide:main Dec 29, 2023
12 checks passed
@James-Pickett
Copy link
Contributor Author

LGTM -- we should probably bump the major version after merge since this changes the signatures for New and CreateKey?

@RebeccaMahany, agree, will tag new release after we test

@directionless
Copy link
Contributor

LGTM -- we should probably bump the major version after merge since this changes the signatures for New and CreateKey?

@RebeccaMahany, agree, will tag new release after we test

Do not bump the major. That creates weird go version issues. Tag a minor release if you like, but I think releases for this are 🤷 and would just point launcher at HEAD

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants