Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #35 - Edge browser color picker not appearing #129

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

alfredosalzillo
Copy link

ISSUE: #35
The input should be visible and the input focused before clicking for EDGE.

ISSUE: kolkov#133
The input should be visible and the input focused before click for EDGE.
@codecov
Copy link

codecov bot commented Aug 6, 2019

Codecov Report

Merging #129 into master will increase coverage by 13.43%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #129       +/-   ##
===========================================
+ Coverage    22.1%   35.54%   +13.43%     
===========================================
  Files           7        7               
  Lines         484      453       -31     
  Branches      102       94        -8     
===========================================
+ Hits          107      161       +54     
+ Misses        365      262      -103     
- Partials       12       30       +18
Impacted Files Coverage Δ
...ar-editor/src/lib/ae-select/ae-select.component.ts 42.02% <0%> (-10.61%) ⬇️
projects/angular-editor/src/lib/config.ts 100% <0%> (ø) ⬆️
...angular-editor/src/lib/angular-editor.component.ts 32.14% <0%> (+14.28%) ⬆️
...s/angular-editor/src/lib/angular-editor.service.ts 22.42% <0%> (+18.69%) ⬆️
...editor/src/lib/angular-editor-toolbar.component.ts 47.11% <0%> (+25.24%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 00eb0e3...54e39f3. Read the comment docs.

Copy link
Owner

@kolkov kolkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for PR. And what about iOS browsers?

@alfredosalzillo
Copy link
Author

Ican't test on IOS.

@kolkov
Copy link
Owner

kolkov commented Aug 7, 2019

Test first please if it possible. Thanks!

@codecov-io
Copy link

Codecov Report

Merging #129 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #129   +/-   ##
=======================================
  Coverage   35.54%   35.54%           
=======================================
  Files           7        7           
  Lines         453      453           
  Branches       94       94           
=======================================
  Hits          161      161           
  Misses        262      262           
  Partials       30       30

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5538b1...54e39f3. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants