fix: support for predefined colors to color picker #327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #327 +/- ##
==========================================
+ Coverage 18.81% 18.98% +0.17%
==========================================
Files 7 7
Lines 473 474 +1
Branches 103 103
==========================================
+ Hits 89 90 +1
Misses 372 372
Partials 12 12 ☔ View full report in Codecov by Sentry. |
kolkov
reviewed
Jun 22, 2021
| @@ -1,5 +1,5 @@ | |||
| import { AngularEditorConfig } from './../../../angular-editor/src/lib/config'; | |||
|
This is very useful functionality. Can we proceed with it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has fixes for aligning the color picker correctly below the button and additionally the pre-defined color options.