New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add stats and change heap #108

Merged

undera merged 5 commits into main from add-anonymous-stats

Nov 24, 2022

Contributor

itielshwartz commented Nov 23, 2022

No description provided.


          add stats and change heap

e9aa61b

Contributor

harshit-mehtaa commented Nov 24, 2022

How to view these stats?

undera reviewed

View reviewed changes

main.go Show resolved Hide resolved

undera reviewed

View reviewed changes

pkg/dashboard/static/list-view.js Outdated Show resolved Hide resolved

undera reviewed

View reviewed changes

pkg/dashboard/static/scripts.js Outdated Show resolved Hide resolved

undera reviewed

View reviewed changes

main.go Outdated Show resolved Hide resolved

undera reviewed

View reviewed changes

pkg/dashboard/server.go Outdated

@@ @@ -35,10 +35,11 @@ func (s Server) StartServer() (string, utils.ControlChan) { @@
               		log.Errorf("Failed to check that Helm is operational, cannot continue. The error was: %s", err)
               		os.Exit(1) // TODO: propagate error instead?
               	}
+              	isDevModeWithAnalytics := s.Version == "0.0.0" && os.Getenv("enableDevAnalytics") == "true"

Collaborator

undera Nov 24, 2022

Env variable should be all-caps and have HD_ prefix, it's a sort of project standard.
The s.Version == "0.0.0" condition is not needed, the second part of condition handles all cases perfectly.

undera reviewed

View reviewed changes

pkg/dashboard/server.go Show resolved Hide resolved

undera requested changes

View reviewed changes

Collaborator

undera left a comment

Please address my comments

Collaborator

undera commented Nov 24, 2022

How to view these stats?

Sorry, it is not possible to view these stats publicly.

itielshwartz added 4 commits

November 24, 2022 12:01


          improve analytics

ac3f3cd


          revert main changes

ec86ed0


          add repo

8c168e7


          Merge remote-tracking branch 'origin/main' into add-anonymous-stats

d6549c3

* origin/main:
  If cluster access is failed, still display UI
  Make the entire card clickable on Installed Charts view (#87)
  Fixes JS part of #95 (#110)

undera merged commit 0b06036 into main

undera deleted the add-anonymous-stats branch

November 24, 2022 10:35

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet