🎨 Remove Superfluous Rule from helm-dashboard ClusterRole #187
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A superfluous rule is added to the ClusterRole upon creation, when the dashboard.allowWriteActions value is set to true. This commit will ensure that only a single rule is created within the ClusterRole, regardless of whether the dashboard.allowWriteActions value is enabled or not.
The verbs within this rule will update accordingly.
Fixes Issue
Closes #186.
Changes proposed
dashboard.allowWriteActions
dashboard.allowWriteActions
istrue
, write-oriented verbs will be includedashboard.allowWriteActions
isfalse
, write-oriented verbs will be excludedCheck List (Check all the applicable boxes)
Note to reviewers
I have tested this locally and confirmed the ClusterRole updates accordingly.