Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎨 Remove Superfluous Rule from helm-dashboard ClusterRole #187

Merged
merged 1 commit into from
Jan 13, 2023
Merged

🎨 Remove Superfluous Rule from helm-dashboard ClusterRole #187

merged 1 commit into from
Jan 13, 2023

Conversation

toddtee
Copy link
Contributor

@toddtee toddtee commented Jan 12, 2023

A superfluous rule is added to the ClusterRole upon creation, when the dashboard.allowWriteActions value is set to true. This commit will ensure that only a single rule is created within the ClusterRole, regardless of whether the dashboard.allowWriteActions value is enabled or not.
The verbs within this rule will update accordingly.

Fixes Issue

Closes #186.

Changes proposed

  • Creates a single rule withing the ClusterRole, rather than two.
  • Verb list for proposed single rule will be updated, according to value of dashboard.allowWriteActions
  • When dashboard.allowWriteActions is true, write-oriented verbs will be include
  • When dashboard.allowWriteActions is false, write-oriented verbs will be excluded

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • The title of my pull request is a short description of the requested changes.

Note to reviewers

I have tested this locally and confirmed the ClusterRole updates accordingly.

A superfluous rule is added to the ClusterRole upon creation,
when the dashboard.allowWriteActions value is set to true.
This commit will ensure that only a single rule is created within
the ClusterRole, regardless of whether the dashboard.allowWriteActions
value is enabled or not.
The verbs within this rule will update accordingly.
@toddtee
Copy link
Contributor Author

toddtee commented Jan 12, 2023

This PR will address Issue #186.

@undera undera merged commit f3c66ec into komodorio:main Jan 13, 2023
@undera
Copy link
Collaborator

undera commented Jan 13, 2023

Welcome to contributors!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Superfluous Rule Created in helm-dashboard ClusterRole (v0.1.2) When dashboard.allowWriteActions is Enabled
2 participants