Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Group
type does not expose the correct set of props.The konva class inherits from
Container
but the props derive fromNodeConfig
.Meaning the props for
Container
, e.g. those related to cropping, are missing.As a result IDEs do not type-hint the relevant properties and tooling may even produce warnings / errors about illegal props getting passed.
The first commit notes the correct type for the Group and Label exports.
The second commit the Group-specific config type from konvajs/konva#1337 instead.