New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add type definitions of pointer event handlers #724

Merged

lavrton merged 2 commits into konvajs:master from pastelmind:pointer-events

Feb 4, 2023

Contributor

pastelmind commented Jan 10, 2023

This PR adds type definitions of event handler props for pointer events:

onPointerDown
onPointerMove
onPointerUp
onPointerCancel
onPointerEnter
onPointerLeave
onPointerOver
onPointerOut
onPointerClick
onPointerDblClick
onGotPointerCapture
onLostPointerCapture

I checked most of them against Konva 8.4.0. However, I could not verify if the following events work properly:

pointercancel: Could not trigger this at all.
gotpointercapture: Works for shapes, but not Stage
lostpointercapture: Works for shapes, but not Stage

Though I believe that they can be fired in the right circumstances.

Resolves #717

pastelmind added 2 commits

January 11, 2023 00:08


          fix typo in comment

701c922


          add pointer event props

e04bb8c

lavrton merged commit cad3803 into konvajs:master

Member

lavrton commented Feb 4, 2023

Thanks. Published.

pastelmind deleted the pointer-events branch

February 5, 2023 03:58

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet