-
-
Notifications
You must be signed in to change notification settings - Fork 266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
React 19 Upgrade #802
React 19 Upgrade #802
Conversation
Thank you so much for your Pull Request. I will review it soon. |
I tried to use the patch in my react-konva based app (that also uses react-konva-utils). I came across the same issues in react-konva-utils (at least I got similar errors messages). So we will probably need the same type of workaround there, |
I'm struggling getting this working on my own. I tried downloading the package, building it, and using that to patch package the current version... but I keep hitting this error:
@jackpope would you be so kind as to publish a version of this as a package? |
I can publish it as beta release. Will do this a bit later.
…On Tue 21 May 2024 at 8:13 PupoSDC ***@***.***> wrote:
I'm struggling getting this working on my own. I tried downloading the
package, building it, and using that to patch package the current
version... but I keep hitting this error:
TypeError: Cannot read properties of undefined (reading 'ReactCurrentOwner')
@jackpope <https://github.com/jackpope> would you be so kind as to
publish a version of this as a package?
—
Reply to this email directly, view it on GitHub
<#802 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AALAL6CHT5WGVX7JEOAOH5DZDNCA3AVCNFSM6AAAAABHLVN4GCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMRSGYYTCMBRGI>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
I released 19.0.0-0. Try it. |
@jackpope I had some issues with |
First testing looks like this is working. Thank you very much for this intermediate release. I will be testing it a bit more thoroughly in the coming days! |
Anyone else getting this in the newer versions? TypeError: reactDom.findDOMNode is not a function |
Running into the same thing with the following:
Is there something I am missing? |
i switched into this versions ,and it start to work! |
As described in #799, React 19 has some breaking changes that will require updates from third-party rendering libraries. I needed to get a new build of react-konva with React 19 working and I wanted to publish the updates here to share the required changes. Hopefully for a new release to go with React 19!
Changes in this PR
commitUpdate