Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop tackle2-addon from manifests #300

Closed
djzager opened this issue Jan 12, 2024 · 3 comments · Fixed by #304
Closed

Drop tackle2-addon from manifests #300

djzager opened this issue Jan 12, 2024 · 3 comments · Fixed by #304
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Milestone
v0.3.1

Comments

@djzager
Copy link
Member

djzager commented Jan 12, 2024

We don't need to reference the tackle2-addon container image in our helm chart/operator manifests. This means that we should remove references to it in:

  1. operator roles (maybe. Not immediately obvious if this is worth the effort)
  2. operator related manifests. presumably most of the occurrences of quay.io/konveyor/tackle2-addon would be a safe bet to remove
  3. build pipeline. NOTE: we need to drop the waiting for the image. we still need to cut the release
@djzager djzager added the cherry-pick/release-0.3 This PR should be cherry-picked to release-0.3 branch. label Jan 12, 2024
@djzager
Copy link
Member Author

djzager commented Jan 12, 2024

this should be included in release-0.3

@djzager djzager added this to Planning Jan 12, 2024
@github-project-automation github-project-automation bot moved this to 🆕 New in Planning Jan 12, 2024
@djzager djzager mentioned this issue Feb 14, 2024
Merged
@djzager djzager removed the cherry-pick/release-0.3 This PR should be cherry-picked to release-0.3 branch. label Feb 14, 2024
@konveyor-ci-bot konveyor-ci-bot bot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Feb 14, 2024
@konveyor-ci-bot
Copy link

This issue is currently awaiting triage.
If contributors determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.
The triage/accepted label can be added by org members.

@konveyor-ci-bot konveyor-ci-bot bot added needs-kind Indicates an issue or PR lacks a `kind/foo` label and requires one. needs-priority Indicates an issue or PR lacks a `priority/foo` label and requires one. labels Feb 14, 2024
@djzager
Copy link
Member Author

djzager commented Feb 14, 2024

/kind cleanup
/priority important-soon
/triage accepted

@djzager djzager moved this from 🆕 New to 🏗 In progress in Planning Feb 14, 2024
@konveyor-ci-bot konveyor-ci-bot bot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-kind Indicates an issue or PR lacks a `kind/foo` label and requires one. needs-priority Indicates an issue or PR lacks a `priority/foo` label and requires one. labels Feb 14, 2024
djzager added a commit that referenced this issue Feb 15, 2024
@djzager
🐛 tackle2-addon is no longer deployed (#304)
a96f97d 
Fixes #300

Signed-off-by: David Zager <[email protected]>
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Planning Feb 15, 2024
djzager added a commit to djzager/tackle2-operator that referenced this issue Feb 15, 2024
@djzager
🐛 tackle2-addon is no longer deployed (konveyor#304)
03cb7d3 
Fixes konveyor#300

Signed-off-by: David Zager <[email protected]>
@djzager djzager mentioned this issue Feb 15, 2024
Merged
@djzager djzager added this to the v0.3.1 milestone Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
Planning
Status: ✅ Done
Milestone
v0.3.1
Development

Successfully merging a pull request may close this issue.

🐛 tackle2-addon is no longer deployed djzager/tackle2-operator
1 participant
@djzager