Apply suggestions from code review

Co-authored-by: Luca Kellermann <[email protected]>
kordlib · Mar 4, 2024 · dd69ed9 · dd69ed9
1 parent 3b3dbb5
commit dd69ed9
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 9 deletions.
diff --git a/buildSrc/src/main/kotlin/kord-multiplatform-module.gradle.kts b/buildSrc/src/main/kotlin/kord-multiplatform-module.gradle.kts
@@ -92,11 +92,7 @@ tasks {
 
     afterEvaluate {
         val compilationTasks = kotlin.targets.flatMap {
-            buildList {
-                add("compileKotlin${it.name.capitalized()}")
-                val sourcesJarName = "${it.name}SourcesJar"
-                add(sourcesJarName)
-            }
+            listOf("compileKotlin${it.name.capitalized()}", "${it.name}SourcesJar")
         }
         for (task in compilationTasks) {
             named(task) {

diff --git a/buildSrc/src/main/kotlin/kord-native-module.gradle.kts b/buildSrc/src/main/kotlin/kord-native-module.gradle.kts
@@ -5,7 +5,7 @@ plugins {
 }
 
 kotlin {
-    // There are issues with compiling the linux variant on linux
+    // There are issues with compiling the linux variant on windows
     // Please use WSL if you need to work on the linux port
     if (!Os.isFamily(Os.FAMILY_WINDOWS)) {
         linuxX64()

diff --git a/samples/src/voiceMain/kotlin/VoiceBot.kt b/samples/src/voiceMain/kotlin/VoiceBot.kt
@@ -36,7 +36,7 @@ fun main(args: Array<String>) = runBlocking {
 }
 
 private suspend fun BaseVoiceChannelBehavior.connectEcho() {
-    val buffer = ArrayList(listOf(AudioFrame.SILENCE, AudioFrame.SILENCE, AudioFrame.SILENCE, AudioFrame.SILENCE))
+    val buffer = mutableListOf(AudioFrame.SILENCE, AudioFrame.SILENCE, AudioFrame.SILENCE, AudioFrame.SILENCE)
     val connection = connect {
         receiveVoice = true
         audioProvider {

diff --git a/test-kit/src/nativeMain/kotlin/Platform.kt b/test-kit/src/nativeMain/kotlin/Platform.kt
@@ -12,7 +12,7 @@ import platform.posix.getenv
 import kotlin.experimental.ExperimentalNativeApi
 import kotlin.native.Platform
 
-private val darwinFamilies = listOf(OsFamily.WATCHOS, OsFamily.TVOS, OsFamily.MACOSX)
+private val darwinFamilies = listOf(OsFamily.WATCHOS, OsFamily.IOS, OsFamily.TVOS, OsFamily.MACOSX)
 
 actual object Platform {
     actual val IS_JVM: Boolean = false

diff --git a/voice/src/commonMain/kotlin/udp/PayloadType.kt b/voice/src/commonMain/kotlin/udp/PayloadType.kt
@@ -7,7 +7,7 @@ public sealed class PayloadType(public val raw: Byte) {
     public object Alive : PayloadType(0x37.toByte())
     public object Audio : PayloadType(0x78.toByte())
     public class Unknown(value: Byte) : PayloadType(value) {
-        override fun toString(): String = raw.toString(16)
+        override fun toString(): String = "PayloadType.Unknown(0x${raw.toString(16)})"
     }
 
     public companion object {