Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add addRoleOverwrite() to Channels Builder too #302

Closed
lulu2002 opened this issue May 23, 2021 · 0 comments · Fixed by #420
Closed

add addRoleOverwrite() to Channels Builder too #302

lulu2002 opened this issue May 23, 2021 · 0 comments · Fixed by #420
Labels
enhancement New feature or request

Comments

@lulu2002
Copy link

the addRoleOverwrite() method provides a much convenient way to modify permissions, If it could also be in Channel Builders, that's gonna be great!
@BartArys BartArys self-assigned this May 24, 2021
@BartArys BartArys added the enhancement New feature or request label May 24, 2021
@BartArys BartArys removed their assignment May 24, 2021
DRSchlaubi added a commit to DRSchlaubi/kord that referenced this issue Oct 13, 2021
@DRSchlaubi
Unify permission overwrite API (Fix kordlib#302)
e71399b
@DRSchlaubi DRSchlaubi mentioned this issue Nov 1, 2021
Merged
HopeBaron pushed a commit that referenced this issue Nov 3, 2021
@DRSchlaubi @BartArys
Unify permission overwrite API (Fix #302) (#420)
07e64fb 
* Unify permission overwrite API (Fix #302)

* Don't use optional in create builders

* Improve documentation of PermissionOverritesBuilder

Co-authored-by: Bart Arys <[email protected]>

* Improve documentation of PermissionOverritesBuilder

Co-authored-by: Bart Arys <[email protected]>

* Improve documentation of PermissionOverritesBuilder

Co-authored-by: Bart Arys <[email protected]>

* Make interface use a function instead of a property

* Make PermissionOverwritesBuilder sealed

Co-authored-by: Bart Arys <[email protected]>

Co-authored-by: Bart Arys <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Unify permission overwrite API (Fix #302) DRSchlaubi/kord
2 participants
@BartArys @lulu2002