Feature: Threads #349
Merged
Feature: Threads #349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's still more modifications to do but hopefully we are close to a milestone in this regards.
BartArys
reviewed
Jul 21, 2021
core/src/main/kotlin/behavior/channel/threads/ThreadParentChannelBehavior.kt
Outdated
Show resolved
Hide resolved
core/src/main/kotlin/behavior/channel/threads/ThreadParentChannelBehavior.kt
Outdated
Show resolved
Hide resolved
core/src/main/kotlin/behavior/channel/threads/ThreadParentChannelBehavior.kt
Outdated
Show resolved
Hide resolved
core/src/main/kotlin/entity/channel/thread/NewsThreadChannel.kt
Outdated
Show resolved
Hide resolved
BartArys
reviewed
Jul 27, 2021
Comment on lines
+193
to
+194
| object ThreeDays : ArchiveDuration(4320) | ||
| object Week : ArchiveDuration(10080) |
There was a problem hiding this comment.
I'm not sure if there's an official documentation out there, but these values are limited to a certain guild boost level, which should be documented.
| @@ -492,6 +494,44 @@ class RestServiceTest { | |||
| updated.delete() | |||
| } | |||
|
|
|||
| @Order(28) | |||
| @Test | |||
| @Disabled("Requires Community Guild") | |||
There was a problem hiding this comment.
This is incorrect. Discord is rolling threads out for all guilds (eventually). These tests should eventually be enabled.
rest/src/main/kotlin/builder/channel/thread/ThreadModifyBuilder.kt
Outdated
Show resolved
Hide resolved
core/src/main/kotlin/behavior/channel/threads/ThreadChannelBehavior.kt
Outdated
Show resolved
Hide resolved
core/src/main/kotlin/behavior/channel/threads/ThreadParentChannelBehavior.kt
Show resolved
Hide resolved
core/src/main/kotlin/behavior/channel/threads/ThreadParentChannelBehavior.kt
Show resolved
Hide resolved
core/src/main/kotlin/behavior/channel/threads/ThreadParentChannelBehavior.kt
Show resolved
Hide resolved
Comment on lines
85
to
96
| internal suspend fun ThreadParentChannelBehavior.startThread( | ||
| name: String, | ||
| archiveDuration: ArchiveDuration, | ||
| type: ChannelType | ||
| ): ThreadChannel { | ||
|
|
||
| val response = | ||
| kord.rest.channel.startPrivateThread(id, StartThreadRequest(name, archiveDuration, Optional.Value(type))) | ||
| val data = ChannelData.from(response) | ||
|
|
||
| return Channel.from(data, kord) as ThreadChannel | ||
| } |
There was a problem hiding this comment.
What's this? and Is itsupposed to be internal?
There was a problem hiding this comment.
Yes, the function abstracts the logic behind starting a thread, but it's not safe to use by the outer-world
There was a problem hiding this comment.
Oh, alright. This should be documented and the name should indicate that this starts a thread without a message
BartArys
reviewed
Jul 28, 2021
Comment on lines
244
to
265
| suspend fun startPublicThread( | ||
| channelId: Snowflake, | ||
| messageId: Snowflake, | ||
| request: StartThreadRequest | ||
| ): DiscordChannel { | ||
| return call(Route.StartPublicThreadPost) { | ||
| keys[Route.ChannelId] = channelId | ||
| keys[Route.MessageId] = messageId | ||
| body(StartThreadRequest.serializer(), request) | ||
| } | ||
| } | ||
|
|
||
|
|
||
| suspend fun startPrivateThread( | ||
| channelId: Snowflake, | ||
| request: StartThreadRequest | ||
| ): DiscordChannel { | ||
| return call(Route.StartPrivateThreadPost) { | ||
| keys[Route.ChannelId] = channelId | ||
| body(StartThreadRequest.serializer(), request) | ||
| } | ||
| } |
There was a problem hiding this comment.
These functions are incorrectly named, they don't create public and private threads respectively.
Comment on lines
85
to
96
| internal suspend fun ThreadParentChannelBehavior.startThread( | ||
| name: String, | ||
| archiveDuration: ArchiveDuration, | ||
| type: ChannelType | ||
| ): ThreadChannel { | ||
|
|
||
| val response = | ||
| kord.rest.channel.startPrivateThread(id, StartThreadRequest(name, archiveDuration, Optional.Value(type))) | ||
| val data = ChannelData.from(response) | ||
|
|
||
| return Channel.from(data, kord) as ThreadChannel | ||
| } |
There was a problem hiding this comment.
Oh, alright. This should be documented and the name should indicate that this starts a thread without a message
BartArys
reviewed
Jul 28, 2021
core/src/main/kotlin/behavior/channel/threads/ThreadChannelBehavior.kt
Outdated
Show resolved
Hide resolved
core/src/main/kotlin/behavior/channel/threads/ThreadChannelBehavior.kt
Outdated
Show resolved
Hide resolved
core/src/main/kotlin/behavior/channel/threads/ThreadChannelBehavior.kt
Outdated
Show resolved
Hide resolved
BartArys
approved these changes
Jul 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds thread support to Kord:
Added a PrivateThreadParent/ThreadParent behaviors to abstract the new functionalities related to channels that can own another channel.
Note: Maybe we should rename those to PrivateThreadOwner and ThreadOwner respectively.
Added support to threads new endpoints / events.
Switched to version 9 for both rest and gateway.