Top channels #353
Merged
Top channels #353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BartArys
reviewed
Aug 1, 2021
Comment on lines
101
to
123
| fun TopGuildChannelBehavior( | ||
| guildId: Snowflake, | ||
| id: Snowflake, | ||
| kord: Kord, | ||
| strategy: EntitySupplyStrategy<*> = kord.resources.defaultStrategy | ||
| ): TopGuildChannelBehavior = object : TopGuildChannelBehavior { | ||
| override val guildId: Snowflake = guildId | ||
| override val id: Snowflake = id | ||
| override val kord: Kord = kord | ||
| override val supplier: EntitySupplier = strategy.supply(kord) | ||
|
|
||
| override fun hashCode(): Int = Objects.hash(id, guildId) | ||
|
|
||
| override fun equals(other: Any?): Boolean = when (other) { | ||
| is GuildChannelBehavior -> other.id == id && other.guildId == guildId | ||
| is ChannelBehavior -> other.id == id | ||
| else -> false | ||
| } | ||
|
|
||
| override fun toString(): String { | ||
| return "TopGuildChannelBehavior(id=$id, guildId=$guildId, kord=$kord, supplier=$supplier)" | ||
| } | ||
| } |
core/src/main/kotlin/Unsafe.kt
Outdated
Comment on lines
38
to
42
| fun guildChannel(guildId: Snowflake, id: Snowflake): GuildChannelBehavior = | ||
| GuildChannelBehavior(guildId = guildId, id = id, kord = kord) | ||
| fun guildChannel(guildId: Snowflake, id: Snowflake): TopGuildChannelBehavior = | ||
| TopGuildChannelBehavior(guildId = guildId, id = id, kord = kord) | ||
|
|
||
| fun guildMessageChannel(guildId: Snowflake, id: Snowflake): GuildMessageChannelBehavior = | ||
| GuildMessageChannelBehavior(guildId = guildId, id = id, kord = kord) | ||
| fun guildMessageChannel(guildId: Snowflake, id: Snowflake): TopGuildMessageChannelBehavior = | ||
| TopGuildMessageChannelBehavior(guildId = guildId, id = id, kord = kord) |
There was a problem hiding this comment.
For correctness, I think these should include top in their name.
Comment on lines
107
to
113
| override fun hashCode(): Int = Objects.hash(id, guildId) | ||
|
|
||
| override fun equals(other: Any?): Boolean = when (other) { | ||
| is GuildChannelBehavior -> other.id == id && other.guildId == guildId | ||
| is ChannelBehavior -> other.id == id | ||
| else -> false | ||
| } |
Comment on lines
26
to
29
| /** | ||
| * The behavior of a Discord channel associated to a [guild]. | ||
| */ | ||
| interface TopGuildChannelBehavior : GuildChannelBehavior { |
There was a problem hiding this comment.
This should explain what constitutes as a top channel, and how it is different from a not-top channel
BartArys
reviewed
Aug 2, 2021
core/src/main/kotlin/behavior/channel/GuildMessageChannelBehavior.kt
Outdated
Show resolved
Hide resolved
core/src/main/kotlin/behavior/channel/TopGuildChannelBehavior.kt
Outdated
Show resolved
Hide resolved
core/src/main/kotlin/behavior/channel/TopGuildMessageChannelBehavior.kt
Outdated
Show resolved
Hide resolved
Co-authored-by: Bart Arys <[email protected]>
Co-authored-by: Bart Arys <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GuildChannelandGuildMessageChannelto include shared behaviors / data between threads and top level channels.