Application commands improvements #374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix NPE on ThreadChannelDelete (#373) * Add missing component options Co-authored-by: shilu <[email protected]>
* Fix NPE on ThreadChannelDelete (#373) * add some missing typesafe option getters Co-authored-by: shilu <[email protected]>
BartArys
reviewed
Aug 28, 2021
Comment on lines
+122
to
+130
| val users: Map<String, User> get() = filterOptions() | ||
|
|
||
| val members: Map<String, Member> get() = filterOptions() | ||
|
|
||
| val channels: Map<String, ResolvedChannel> get() = filterOptions() | ||
|
|
||
| val roles: Map<String, Role> get() = filterOptions() | ||
|
|
||
| val mentionables: Map<String, Entity> get() = filterOptions() |
There was a problem hiding this comment.
Don't these keys represent Snowflakes?
There was a problem hiding this comment.
those could be shorthanded from resolved. I think last time we talked about this we said that not all resolved values are in options
There was a problem hiding this comment.
it would work fine, each of those should be a part of options
…m/kordlib/kord into application-commands-improvements
BartArys
approved these changes
Aug 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.