Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add named files and attachments #379

Merged
merged 3 commits into from
Sep 5, 2021
Merged

add named files and attachments #379

merged 3 commits into from
Sep 5, 2021

Conversation

HopeBaron
Copy link
Member

fixes #372

@HopeBaron HopeBaron requested a review from BartArys August 29, 2021 07:58
Copy link
Contributor

@BartArys BartArys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's no easy way for the user to convert an Attachment to a DiscordAttachment in core, I don't see this as easy to use at all.

components = state.components.mapList { it.build() },
embeds = state.embeds.mapList { it.toRequest() },
flags = Optional(MessageFlags(MessageFlag.Ephemeral))
attachments = state.attachments
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

attachments aren't declared anywhere in the builder itself

@HopeBaron
Copy link
Member Author

I haven't had a clear way to do it yet either wither we will apply the same utility functions that already exist for embeds

@HopeBaron HopeBaron merged commit a9f36c0 into 0.8.x Sep 5, 2021
@HopeBaron HopeBaron deleted the attached-files branch October 7, 2021 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing attachments for message/webhook edit
2 participants