Add missing invitable field
#398
Conversation
|
shouldn't this be added to the create data as well |
Yes, I forgot about that, let me add it there too |
|
Done 😊 |
|
I guess you missed the thread create builder as well |
I think that a ThreadCreateBuilder doesn't exist (yet) :(
|
|
it's called the StartThreadRequest but since properties are being added to it maybe make a builder if you will. |
|
I added the |
| reason: String? = null, | ||
| ): TextChannelThread { | ||
| return unsafeStartThread(name, archiveDuration, ChannelType.PublicGuildThread, reason) as TextChannelThread | ||
| return unsafeStartThread( | ||
| name, | ||
| archiveDuration, | ||
| ChannelType.PublicGuildThread | ||
| ) { | ||
| this.reason = reason | ||
| } as TextChannelThread |
There was a problem hiding this comment.
remove the reason from here, add the builder as a part of the function
so:
suspend fun startPublicThread(
name: String,
archiveDuration: ArchiveDuration = ArchiveDuration.Day,
builder: StartThread.() -> Unit
): TextChannelThreadand then pass it to unsafe
| import dev.kord.rest.builder.AuditRequestBuilder | ||
| import dev.kord.rest.json.request.StartThreadRequest | ||
|
|
||
| class StartThreadBuilder(var name: String, var autoArchiveDuration: ArchiveDuration, var type: ChannelType) : AuditRequestBuilder<StartThreadRequest> { |
There was a problem hiding this comment.
make type a val here, you don't want to make a switch in the types which makes the builder no longer useful.
There was a problem hiding this comment.
Only val for the ChannelType, or for name and autoArchiveDuration too?
The
invitablefield controls this option