Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable explicit api mode for core module #406

Merged
merged 1 commit into from
Oct 3, 2021

Conversation

NyCodeGHG
Copy link
Contributor

Enables explicit api mode for the core module as discussed on the discord server.
CI will fail because @ByteAlex broke the test :)

@ByteAlex
Copy link
Contributor

ByteAlex commented Oct 1, 2021

And what exactly did I break? 🤔

@NyCodeGHG
Copy link
Contributor Author

i don't actually now, i rebased onto the latest commit and now that test is failing

@HopeBaron
Copy link
Member

I fixed it, you used an asChannel instead of fetchChannel in one test.

@HopeBaron HopeBaron added the hacktoberfest-accepted Pull requests participating in hacktoberfest label Oct 1, 2021
@NyCodeGHG NyCodeGHG force-pushed the feature/explicit-api-mode branch from 94d1cd0 to a4d75dc Compare October 3, 2021 12:31
@HopeBaron HopeBaron merged commit 0bb8163 into kordlib:0.8.x Oct 3, 2021
@NyCodeGHG NyCodeGHG deleted the feature/explicit-api-mode branch October 3, 2021 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Pull requests participating in hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants