Voice Concurrency #423
Merged
Voice Concurrency #423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This doesn't seem to be based of #386 |
HopeBaron
reviewed
Oct 18, 2021
| */ | ||
| fun connect() = launch { | ||
| voiceGateway.start(voiceGatewayConfiguration) | ||
| suspend fun connect(context: CoroutineContext = EmptyCoroutineContext) { |
There was a problem hiding this comment.
would probably be better to make this a scope and default to this
lost-illusi0n
force-pushed
the
features/0.8.x/voice-concurrency
branch
from
b198bee to
cc7a562
Compare
lost-illusi0n
force-pushed
the
features/0.8.x/voice-concurrency
branch
from
cc7a562 to
7136523
Compare
lost-illusi0n
force-pushed
the
features/0.8.x/voice-concurrency
branch
from
9bb8cb4 to
b49a45f
Compare
|
ill do the same thing with the other PRs that dependent on this one, once this is merged |
HopeBaron
added
the
hacktoberfest-accepted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the coroutine-related downfalls in the current voice implementation. There should no longer be any lingering coroutines after calling
shutdownon aVoiceConnection. This PR also tries to adhere to a more defined coroutine structure, along with polishing some reconnection/disconnection logic.Based off of #386