Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add AutoComplete #435

Merged
merged 14 commits into from
Nov 25, 2021
Merged

Add AutoComplete #435

merged 14 commits into from
Nov 25, 2021

Conversation

DRSchlaubi
Copy link
Member

@DRSchlaubi DRSchlaubi commented Oct 28, 2021 •
edited by BartArys
Loading

discord/discord-api-docs#3996

  • Add support for AutoComplete options
  • Update Core representation

@DRSchlaubi DRSchlaubi force-pushed the feature/autocomplete branch from 0585983 to 441754d Compare October 28, 2021 16:28
@DRSchlaubi DRSchlaubi force-pushed the feature/autocomplete branch from 0346acf to f60a193 Compare October 28, 2021 20:11
@DRSchlaubi
Copy link
Member Author

@HopeBaron Those classes are in the core module, the file above is rest, so these links don't work
No idea why but couldn't reply to your convo above directly

@HopeBaron
Copy link
Member

There is no need for such documentation when you can't refer to it. rest module is unaware of events.

This sort of documentation may become invalid since refactoring may now work on those so they will become lies if things change. And Kord has already enough of those kinds of documentation that we should be working on already.
Remove them for now also I'd like you to integrate warnings and Notes without bold headers.

@HopeBaron
Copy link
Member

why "MessageResponding"
I guess you mixed it up with InteractionResponse?

@DRSchlaubi
Copy link
Member Author

Because these interactions respond with a Message unlike AutoComplete which respond with a Choices object.

I think it was @BartArys who suggested MessageResponding

@DRSchlaubi
Update docs according
c9e595b
@DRSchlaubi
Update docs according to requested changes
f400e77
@DRSchlaubi
Merge remote-tracking branch 'origin/0.8.x' into feature/autocomplete
7f27bbe 
# Conflicts:
#	common/src/main/kotlin/entity/Interactions.kt
#	core/src/main/kotlin/entity/application/ChatInputCommandCommand.kt
@HopeBaron
Copy link
Member

not all commands should respond with a message. it may be a command with no message, and chatinput now implements only Interaction instead of ApplicationCommandInteraction
I don't get why this happened...

They are all application commands, it's just that AutoComplete responds diferently, right?

@DRSchlaubi
Copy link
Member Author

and chatinput now implements only Interaction instead of ApplicationCommandInteraction
I don't get why this happened...

Okay that was unintended

They are all application commands, it's just that AutoComplete responds diferently, right?

yes this is why MessageRespondingInteraction is everything but autocomplete, but I am open for better names

@HopeBaron HopeBaron merged commit 93c6366 into kordlib:0.8.x Nov 25, 2021
@DRSchlaubi DRSchlaubi mentioned this pull request Feb 12, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BartArys BartArys BartArys left review comments

@HopeBaron HopeBaron HopeBaron requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DRSchlaubi @HopeBaron @BartArys