Change members resolved objects to DiscordInteractionGuildMember instead of DiscordGuildMember
#502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stead of DiscordGuildMember
MrPowerGamerBR
added a commit
to LorittaBot/DiscordInteraKTions
that referenced
this pull request
Jan 25, 2022
Does not compile because kordlib/kord#502 needs to be merged first
lukellmann
approved these changes
Feb 4, 2022
MrPowerGamerBR
added a commit
to LorittaBot/DiscordInteraKTions
that referenced
this pull request
Feb 9, 2022
…ace, use our own custom Kord fork for now (#22) * Add more fields to the Member interface, add InteractionMember interface Does not compile because kordlib/kord#502 needs to be merged first * Use our own fork while Kord our changes aren't merged yet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example of the resolved objects object:
{"data":{"type":1,"resolved":{"users":{"330416853971107840":{"username":"Welcomer","public_flags":589824,"id":"330416853971107840","discriminator":"5491","bot":true,"avatar":"5f65708fd35ee3844a463d5bf9fe7828"}},"members":{"330416853971107840":{"roles":["334711955736625185","401353261266763778","703308276770668634"],"premium_since":null,"permissions":"2199023255551","pending":false,"nick":null,"joined_at":"2020-04-24T18:16:00.039000+00:00","is_pending":false,"communication_disabled_until":null,"avatar":null}}}Currently Kord uses
DiscordGuildMemberwhich does not have thepermissionsfield, however Discord does provide thepermissionsfield to resolved objects within an interaction.By comparing Discord's documentation + the resolved objects map, it makes way more sense to use the
DiscordInteractionGuildMemberinstead ofDiscordGuildMemberfor the resolved objects map, because:permissionsfield is present, which isn't present in theDiscordGuildMembermuteanddeafenfields are missing, which are not present in theDiscordInteractionGuildMember