Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for modals #528

Closed
wants to merge 8 commits into from
Closed

Conversation

MrPowerGamerBR
Copy link
Contributor

You can already receive modals via the gateway and send modals via REST

#527

You can already receive modals via the gateway and send modals via REST
}

public suspend inline fun createIntAutoCompleteInteractionResponse(
public inline suspend fun createIntAutoCompleteInteractionResponse(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's suspend inline fun everywhere else, why change it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Honestly I'm not sure why I shuffled that, I think I removed the inline by mistake so IDEA was complaining, so when I readded them I added them in a non-canonical order

) : DiscordComponent()

@Serializable
public data class ActionRowComponent(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DiscordActionRowComponent to avoid confusion with core naming (applies to all DiscordComponent subtypes)

@MrPowerGamerBR
Copy link
Contributor Author

MrPowerGamerBR commented Feb 9, 2022

I already implemented the classes in the core module and now Kord compiles, yay!

I haven't implemented the events because I'm not really knowledgeable with the core module (because I don't use it 😭) so if anyone wants to implement the events, feel free to do it, everything else should be already OK and working fine. (If anyone wants to do it, just tell me and create a PR to my fork)

(Or maybe I will do it myself later)

@HopeBaron
Copy link
Member

merged to #531

@HopeBaron HopeBaron closed this Feb 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants