Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add inspection for missing @KordDsl #800

Merged
merged 6 commits into from
Mar 30, 2023
Merged

Add inspection for missing @KordDsl #800

merged 6 commits into from
Mar 30, 2023

Conversation

DRSchlaubi
Copy link
Member

@DRSchlaubi DRSchlaubi commented Mar 30, 2023 •
edited by lukellmann
Loading

If a subtype of dev.kord.rest.builder.RequestBuilder does not have the @KordDsl annotation, there will be an error.

lukellmann
lukellmann reviewed Mar 30, 2023
View reviewed changes
Copy link
Member

@lukellmann lukellmann left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we also check if all of the annotated classes have an appropiate supertype? rn it checks for missing annotations, we could also check for wrong annotations.

ksp-processors/src/main/kotlin/inspection/BuilderDslMarkerInspectionProcessor.kt Outdated Show resolved Hide resolved
ksp-processors/src/main/kotlin/KSPUtils.kt Outdated Show resolved Hide resolved
ksp-processors/src/main/kotlin/KSPUtils.kt Outdated Show resolved Hide resolved
ksp-processors/src/main/kotlin/inspection/BuilderDslMarkerInspectionProcessor.kt Outdated Show resolved Hide resolved
ksp-processors/src/main/kotlin/inspection/BuilderDslMarkerInspectionProcessor.kt Outdated Show resolved Hide resolved
ksp-processors/src/main/kotlin/inspection/BuilderDslMarkerInspectionProcessor.kt Outdated Show resolved Hide resolved
ksp-processors/src/main/kotlin/inspection/BuilderDslMarkerInspectionProcessor.kt Outdated Show resolved Hide resolved
lukellmann
lukellmann approved these changes Mar 30, 2023
View reviewed changes
Copy link
Member

@lukellmann lukellmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks :)

@lukellmann lukellmann merged commit 8c79679 into 0.9.x Mar 30, 2023
@lukellmann lukellmann deleted the feature/dsl-marker-inspection branch March 30, 2023 20:40
@lukellmann lukellmann changed the title Add inspection for @DslMarker Add inspection for missing @KordDsl Mar 30, 2023
@lukellmann lukellmann changed the title Add inspection for missing @KordDsl Add inspection for missing @KordDsl Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukellmann lukellmann lukellmann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DRSchlaubi @lukellmann