-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add interaction channel field #810
Add interaction channel field #810
Conversation
i think there is no need for a new partial channel type, the exisiting |
any updates on this @NoComment1105 ? |
I saw this, I read this, I forgot about this. I'll sort it now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should also add a Interaction.channelType
property taken from this new channel
field
core/src/commonMain/kotlin/behavior/interaction/InteractionBehavior.kt
Outdated
Show resolved
Hide resolved
core/src/commonMain/kotlin/behavior/interaction/InteractionBehavior.kt
Outdated
Show resolved
Hide resolved
Co-authored-by: Lukellmann <[email protected]>
core/src/commonMain/kotlin/behavior/interaction/ChannelInteractionBehavior.kt
Outdated
Show resolved
Hide resolved
Can this be reviewed please @lukellmann ? |
ah yes, forgot about it, will try to get to it today |
core/src/commonMain/kotlin/behavior/interaction/ChannelInteractionBehavior.kt
Outdated
Show resolved
Hide resolved
after thinking about this for a bit, i think it might actually be better (and would result in way less intrusive changes) to just change the logic for getting the what do you think? |
That sounds better actually, I'll look into doing that ASAP. Sorry I've missed this for so long 😄 |
@lukellmann I have made your changes, could you please review them? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
except for all the redundant overrides (only Interaction.channelId
should need to be changed) this looks good 👍
core/src/commonMain/kotlin/behavior/interaction/ActionInteractionBehavior.kt
Outdated
Show resolved
Hide resolved
core/src/commonMain/kotlin/behavior/interaction/ApplicationCommandInteractionBehavior.kt
Outdated
Show resolved
Hide resolved
core/src/commonMain/kotlin/behavior/interaction/ComponentInteractionBehavior.kt
Outdated
Show resolved
Hide resolved
core/src/commonMain/kotlin/behavior/interaction/GuildInteractionBehavior.kt
Outdated
Show resolved
Hide resolved
core/src/commonMain/kotlin/entity/interaction/GuildInteraction.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for all the effort 😅
Implements a partial channel object for this. As there was not one before
discord/discord-api-docs@88a7618