Change parentId and lockPermissionsToParent to Optionals
#828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Always forget API changes... 🙃 |
The documentation was incorrect regarding these fields' optionality, and as such it was impossible to swap multiple channels in one request. By changing these fields to Optionals (like `position` already was), this issue is fixed. Closes kordlib#827
Tmpod
force-pushed
the
task/827/channel-position-request-optional-fields
branch
from
ca39c2a to
0b0b734
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The documentation was incorrect regarding these fields' optionality, and as such it was impossible to swap multiple channels in one request. By changing these fields to Optionals (like
positionalready was), this issue is fixed.Closes #827