Support Kotlin/Native #855

DRSchlaubi · 2023-08-05T23:23:06Z

This PR aims at implementing Kotlin/Native for the following platforms:

linuxX64
linuxArm64
mingwX64
macosArm64
macosX64
iosArm64
iosX64
iosSimulatorArm64
watchosX64
watchosArm64
watchosSimulatorArm64
tvosX64
tvosArm64
tvosSimulatorArm64

Experimental Snapshot

There currently is an experimental snapshot on OSSRH under the feature-native-SNAPSHOT for you to try

An example implementation can be found here

Please note that you need to configure the Ktor EAP repository:

Gradle Configuration

repositories {
    // Required for Ktor EAP build
    maven("https://maven.pkg.jetbrains.space/public/p/ktor/eap/")
    maven("https://oss.sonatype.org/content/repositories/snapshots/")
    mavenCentral()
}

kotlin {
  sourceSets {
    commonMain {
      dependencies {
        implementation("dev.kord:kord-core:feature-native-SNAPSHOT")
      }
    }
  }
}

Current limitations

Requires Ktor 3.1.0 EAP builds

Checklist

Add support for Native cache#12
Add support for Kotlin/JS and Kotlin/Native kordx.emoji#23
Port voice to native (cc @lost-illusi0n)
Configure CI (kordlib/.teamcity
Release a new native compatible version of cache
Release kordlib/setup-curl
Release kordlib/docker
Release Kord/Native
Release kordx.emoji

Blocked by

~~KTOR-5199 Support WebSockets in Curl engine ktorio/ktor#3950~~ (Merged in Update libcurl to 8.11.1 with enabled websockets ktorio/ktor#4588)
~~Switch to TeamCity and Qodana #822~~ (Combined into this)
Add support for Native cache#12
~~TW-86481~~ (Fixed)

lukellmann · 2023-08-05T23:48:52Z

can't wait to run my bot on an apple watch

lukellmann · 2023-08-05T23:57:30Z

what's this commit? seems to be related to #836 but that is already on main.

DRSchlaubi · 2023-08-06T12:06:42Z

When I compiled these files were generated

DRSchlaubi · 2023-08-06T12:07:32Z

can't wait to run my bot on an apple watch

Need to buy one again for this, or ask @melike2d

viztea · 2023-08-06T12:08:38Z

can't wait to run my bot on an apple watch

Need to buy one again for this, or ask @melike2d

can't believe you think i have enough money for that

lukellmann · 2023-08-06T12:24:23Z

When I compiled these files were generated

the one in the build dir, sure, but the other ones?

The use of value classes for the Reset class has already caused issues implementing #855. However, it was isolated to native platforms. Unfortunately, this behavior will become a compiler error soon, so we need to change it. This can be achieved by simply using the backing Instant instead of Reset with AtomicRef. Related Issues: #855 #69 Kotlin/kotlinx-atomicfu#291 https://youtrack.jetbrains.com/issue/KT-61584 Co-authored-by: lukellmann <[email protected]>

DRSchlaubi · 2024-02-29T15:26:24Z

A workaround for the blocking teamcity bug has been implemented, snapshots are now published to feature-native-SNAPSHOT

- Migrate test-kit to use kotlinx-resources

- revert back to own test file handler - update yarn lock - Fix task dependencies

I spent way too much time reading documentation...

# Conflicts: # .github/workflows/gradle-wrapper-validation.yml # buildSrc/src/main/kotlin/kord-internal-multiplatform-module.gradle.kts # buildSrc/src/main/kotlin/kord-module.gradle.kts # buildSrc/src/main/kotlin/kord-multiplatform-module.gradle.kts # core/api/core.api # core/api/core.klib.api # core/live-tests/build.gradle.kts # core/src/commonMain/kotlin/Kord.kt # gateway/api/gateway.api # gateway/api/gateway.klib.api # gateway/src/commonMain/kotlin/Gateway.kt # gateway/src/commonMain/kotlin/Inflater.kt # gateway/src/commonMain/kotlin/Utils.kt # gradle/libs.versions.toml # voice/api/voice.api # voice/src/commonMain/kotlin/gateway/VoiceGateway.kt

lukellmann · 2024-07-05T21:53:33Z

core/src/commonTest/kotlin/performance/KordEventDropTest.kt

@@ -63,6 +64,8 @@ class KordEventDropTest {
    )

    @Test
+    // This test seems to timeout sometimes on native
+    @IgnoreOnNative


can we increase/remove the timeout as with js? #926

# Conflicts: # gradle/libs.versions.toml

# Conflicts: # .github/workflows/deployment-ci.yml # .github/workflows/docs-ci.yml # buildSrc/src/main/kotlin/kord-internal-multiplatform-module.gradle.kts # buildSrc/src/main/kotlin/kord-module.gradle.kts # buildSrc/src/main/kotlin/kord-multiplatform-module.gradle.kts # buildSrc/src/main/kotlin/kord-publishing.gradle.kts # core/src/commonMain/kotlin/Kord.kt # gateway/src/commonMain/kotlin/Gateway.kt # gateway/src/commonMain/kotlin/Utils.kt # gradle/libs.versions.toml # ksp-annotations/build.gradle.kts # voice/src/commonMain/kotlin/gateway/VoiceGateway.kt

common/src/nonJvmMain/kotlin/DiscordBitSet.kt

arslanarm · 2025-01-22T17:43:44Z

is there any work done about this merge request, I just skimmed the blockers, KTOR-5199 was resolved in separate pull request. kordx.emoji support for native being blocker for kord-core(native) is a bit weird. Is moving to TeamCity and Qodana the main blocker for this mr? or are we just waiting for an approval?

DRSchlaubi · 2025-01-30T20:51:27Z

Currently awaiting release with that PR merged

- Switch to official Ktor EAP builds

DRSchlaubi · 2025-02-01T18:32:12Z

This is now built upon Ktor's EAP builds so updating should be a lot easier, since we no longer need to compile Ktor ourselves, we likely won't be able to merge this when Ktor 3.1.0 lands, however we will continue to provide experimental builds

DRSchlaubi requested review from HopeBaron and lukellmann August 5, 2023 23:23

DRSchlaubi self-assigned this Aug 5, 2023

DRSchlaubi mentioned this pull request Aug 5, 2023

Initial migration to native #808

Closed

DRSchlaubi mentioned this pull request Aug 6, 2023

Support kord-voice on Kotlin/JS and Windows #69

Open

8 tasks

DRSchlaubi linked an issue Aug 6, 2023 that may be closed by this pull request

Support kord-voice on Kotlin/JS and Windows #69

Open

8 tasks

DRSchlaubi mentioned this pull request Aug 31, 2023

Don't use value class Reset with AtomicRef #863

Merged

DRSchlaubi force-pushed the feature/native branch from 1f7f641 to 0724654 Compare January 24, 2024 17:50

This was referenced Jan 26, 2024

Status on multiplatform kordlib/Lavalink.kt#2

Open

Switch to TeamCity and Qodana #822

Closed

DRSchlaubi marked this pull request as ready for review January 30, 2024 18:55

DRSchlaubi changed the title ~~Add support for Kotlin/Native~~ Support Kotlin/Native Jan 30, 2024

This was referenced Feb 6, 2024

Improve publishing #854

Closed

Get rid of gh-pages branch #815

Closed

DRSchlaubi added 8 commits February 29, 2024 16:29

Add native targets to KMP modules

ab37ea3

- Migrate test-kit to use kotlinx-resources

Disable CI for now

537a01b

Use hierarchies for all KMP targets

540aee2

Add missing generated files

e019272

Add missing generated types

6d91b32

Fix tests

1ed902e

- revert back to own test file handler - update yarn lock - Fix task dependencies

Fix weird atomic issues on native

92ab453

Implement Throwable.isTimeout() on native

e8007c1

lukellmann and others added 6 commits April 22, 2024 23:06

Tweaks to native Inflater

c598338

I spent way too much time reading documentation...

Remaining upgrades

fa06f85

Add missing opt ins

00d8b98

Fix build

0bb2550

Fix build

9d86e31

lukellmann reviewed Jul 5, 2024

View reviewed changes

DRSchlaubi and others added 8 commits July 18, 2024 18:23

Merge remote-tracking branch 'origin/main' into feature/native

fc4007a

# Conflicts: # gradle/libs.versions.toml

Update to Ktor 3.0.0-beta-2

4ea3199

More fixes in regards to merge

6cf5769

Remove duplicate -Xexpect-actual-classes

a08068b

Imports, formatting

10834bf

Remove unused version

3dd43e1

Remove unused -Xcontext-receivers in buildSrc

86ddabb

lukellmann reviewed Sep 18, 2024

View reviewed changes

common/src/nonJvmMain/kotlin/DiscordBitSet.kt Outdated Show resolved Hide resolved

DRSchlaubi added 2 commits October 21, 2024 13:44

Merge remote-tracking branch 'origin/main' into feature/native

d4d792c

Update to current state of main

1362153

DRSchlaubi added 3 commits February 1, 2025 18:47

Merge branch 'main' into feature/native

1fdb05c

Update dependencies

1a96b25

- Switch to official Ktor EAP builds

Use ktor-network for all targets

1e89839

Update Gradle to 8.12

7d65aa9

DRSchlaubi force-pushed the feature/native branch from f4d70cc to 7d65aa9 Compare February 1, 2025 18:32

DRSchlaubi added 4 commits February 1, 2025 19:32

Update Gradle to 8.12.1

5dc199d

Upgrade yarn.lock

b43ff98

Fix build

dee7dd8

API dump

e15c143

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support Kotlin/Native #855

Support Kotlin/Native #855

DRSchlaubi commented Aug 5, 2023 •

edited

Loading

lukellmann commented Aug 5, 2023

lukellmann commented Aug 5, 2023

DRSchlaubi commented Aug 6, 2023

DRSchlaubi commented Aug 6, 2023

viztea commented Aug 6, 2023

lukellmann commented Aug 6, 2023

DRSchlaubi commented Feb 29, 2024

lukellmann Jul 5, 2024

arslanarm commented Jan 22, 2025

DRSchlaubi commented Jan 30, 2025

DRSchlaubi commented Feb 1, 2025

Support Kotlin/Native #855

Are you sure you want to change the base?

Support Kotlin/Native #855

Conversation

DRSchlaubi commented Aug 5, 2023 • edited Loading

Experimental Snapshot

Current limitations

Checklist

Blocked by

lukellmann commented Aug 5, 2023

lukellmann commented Aug 5, 2023

DRSchlaubi commented Aug 6, 2023

DRSchlaubi commented Aug 6, 2023

viztea commented Aug 6, 2023

lukellmann commented Aug 6, 2023

DRSchlaubi commented Feb 29, 2024

lukellmann Jul 5, 2024

Choose a reason for hiding this comment

arslanarm commented Jan 22, 2025

DRSchlaubi commented Jan 30, 2025

DRSchlaubi commented Feb 1, 2025

DRSchlaubi commented Aug 5, 2023 •

edited

Loading